From 5309c1c643d0ff9418bccdea5d9c0f8e74ac0f28 Mon Sep 17 00:00:00 2001 From: Eulan2025 Date: Tue, 23 Sep 2025 13:36:48 +0800 Subject: [PATCH] fix: Flaky DDK test Remove indirect reliance in Xtext UI services by creating a real XtextResource instead. --- .../CheckRewritableImportSectionFactoryTest.xtend | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/imports/test/CheckRewritableImportSectionFactoryTest.xtend b/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/imports/test/CheckRewritableImportSectionFactoryTest.xtend index 40b8fe54f8..726f4afb55 100644 --- a/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/imports/test/CheckRewritableImportSectionFactoryTest.xtend +++ b/com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/imports/test/CheckRewritableImportSectionFactoryTest.xtend @@ -14,16 +14,12 @@ package com.avaloq.tools.ddk.check.imports.test import com.avaloq.tools.ddk.check.core.test.AbstractCheckTestCase import com.avaloq.tools.ddk.check.imports.CheckRewritableImportSectionFactory import com.google.inject.Inject -import org.eclipse.emf.common.util.BasicEList import org.eclipse.emf.common.util.URI -import org.eclipse.emf.ecore.EObject import org.eclipse.xtext.resource.XtextResource import org.eclipse.xtext.testing.XtextRunner import org.junit.Test import org.junit.runner.RunWith -import static org.mockito.Mockito.mock -import static org.mockito.Mockito.when /** * Tests for {@link CheckRewritableImportSectionFactoryTest}. @@ -47,14 +43,10 @@ class CheckRewritableImportSectionFactoryTest extends AbstractCheckTestCase { @Test def void testParseSuccessful() { // ARRANGE - val mockResource = mock(XtextResource) - when(mockResource.contents).thenReturn(new BasicEList()); - val mockUri = mock(URI) - when(mockResource.URI).thenReturn(mockUri); - when(mockUri.trimFragment).thenReturn(mockUri) + val resource = resourceSet.createResource(URI.createURI("dummy:/test")) as XtextResource // ACT - val rewritableImportSection = factory.parse(mockResource) + val rewritableImportSection = factory.parse(resource) // ASSERT assertNotNull("parse() should return an object", rewritableImportSection) @@ -62,3 +54,4 @@ class CheckRewritableImportSectionFactoryTest extends AbstractCheckTestCase { } } +