Skip to content

Things to do for fixed PR #9

Description

@MxmUrw
  • Describe how field size, fixed point bits, vector length relate
  • Improve comments (delete slash-lines, better text)
  • Remove panics/unwraps
  • cargo fmt, rustfmt, clippy
  • comments lines are 80 chars
  • docucomment lines are 100 chars
  • encode_measurement: merge first iteration over vector entries with second, remove max-check because subroutine already does it
  • describe that we actually only allow norms < 1 (consider mitigations?)
  • write a huge block comment explaining what's going on
  • test: vector with too-big norm, vector with norm that differs from claim, non-zero-one-vector, some succeeding vectors using positive and negative numbers
  • questions to ask:
    • what to do about the tests (from sum) which expect failures in prio3
    • is there an explanation for the "verifier_len" field?
    • Is making flp_validity_test crate public the correct approach for using it in multiple files?
  • rename num_clients to num_shares in validation function (parallel and not parallel version of type)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions