Skip to content

fix(postman): fall back to English (id=1) when _getdefault returns invalid id (#35780) #35817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsolistorres wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −6
Open

fix(postman): fall back to English (id=1) when _getdefault returns invalid id (#35780) #35817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions dotcms-postman/src/main/resources/postman/GraphQLTests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14878,9 +14878,13 @@
" throw new Error('Could not resolve default language: HTTP ' + response.code);",
" }",
" const body = response.json();",
" const id = body && body.entity && body.entity.id;",
" if (!id) {",
" throw new Error('Could not resolve default language: entity.id missing in response');",
" let id = body && body.entity && body.entity.id;",
" if (!id || id <= 0) {",
" // _getdefault can return the LANG__404 sentinel (id=-1) in fresh",
" // test environments. Fall back to English (id=1), which is always",
" // present in dotCMS starter data. See issue #35780.",
" console.log('Default language returned invalid id (' + id + '), falling back to English (id=1)');",
" id = 1;",
" }",
" pm.environment.set('defaultLanguageId', id);",
" console.log('defaultLanguageId = ' + id);",
Expand Down
10 changes: 7 additions & 3 deletions dotcms-postman/src/main/resources/postman/Workflow_Resource_Tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19851,9 +19851,13 @@
" throw new Error('Could not resolve default language: HTTP ' + response.code);",
" }",
" const body = response.json();",
" const id = body && body.entity && body.entity.id;",
" if (!id) {",
" throw new Error('Could not resolve default language: entity.id missing in response');",
" let id = body && body.entity && body.entity.id;",
" if (!id || id <= 0) {",
" // _getdefault can return the LANG__404 sentinel (id=-1) in fresh",
" // test environments. Fall back to English (id=1), which is always",
" // present in dotCMS starter data. See issue #35780.",
" console.log('Default language returned invalid id (' + id + '), falling back to English (id=1)');",
" id = 1;",
" }",
" pm.environment.set('defaultLanguageId', id);",
" console.log('defaultLanguageId = ' + id);",
Expand Down
Loading