Skip to content
This repository was archived by the owner on Jul 30, 2018. It is now read-only.
This repository was archived by the owner on Jul 30, 2018. It is now read-only.

lang.mixin errors with null target #409

@odoe

Description

@odoe

Enhancement

Currently, it doesn't look like @dojo/core/lang#mixin handles null targets.
I don't think a user would intentionally pass undefined or null, but I ran across this when transitioning from Dojo 1 to Dojo 2. The Dojo 1 mixin method does handles this use case.

Maybe this expected behavior and users of mixin should handle this on a case by case basis, but felt I should bring it up anyway.

Package Version: 2.0.0

const obj = mixin(undefined, { age: 40 });

https://codesandbox.io/s/zwovr308jx - Dojo 2
http://jsbin.com/bufiyi/2/edit?html,js,console - Dojo 1

Expected behavior:

const obj = mixin(undefined, { age: 40 }); // { age: 40 }

Actual behavior:

const obj = mixin(undefined, { age: 40 }); //Type Error Cannot set property 'name' of null

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions