From f6414f29eb8160d7ff6f2365cbe6e7203bcf0eed Mon Sep 17 00:00:00 2001 From: Kroese Date: Mon, 20 Jul 2026 15:03:43 +0200 Subject: [PATCH 1/2] fix: Resolve shellcheck warnings --- .github/workflows/check.yml | 45 ++++++++++++++++++++----------------- 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 5b2bc93..ff7714e 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -1,5 +1,7 @@ on: [workflow_call] + name: "Check" + permissions: {} jobs: @@ -7,24 +9,27 @@ jobs: name: shellcheck runs-on: ubuntu-latest steps: - - - name: Checkout code - uses: actions/checkout@v7 - - parallel: - - - name: Run ShellCheck - uses: ludeeus/action-shellcheck@master - env: - SHELLCHECK_OPTS: -x --source-path=src -e SC2064 -e SC2114 -e SC2129 -e SC2034 -e SC1087 -e SC2317 -e SC2046 - - - name: Lint Dockerfile - uses: hadolint/hadolint-action@v3.3.0 - with: - dockerfile: Dockerfile - ignore: DL3008,DL3018,DL3020,DL3029,DL3059,DL4006,DL4001,SC2114,DL3006,DL3027,DL3003,SC2016 - failure-threshold: warning - - name: Validate JSON and YML files - uses: GrantBirki/json-yaml-validate@v5.0.0 - with: - yaml_exclude_regex: ".*\\kubernetes\\.yml$" + name: Checkout code + uses: actions/checkout@v7 + - parallel: + - + name: Run ShellCheck + uses: ludeeus/action-shellcheck@master + env: + SHELLCHECK_OPTS: >- + -x + --source-path=src + -e SC2129 + -e SC2034 + -e SC2317 + - + name: Lint Dockerfile + uses: hadolint/hadolint-action@v3.3.0 + with: + dockerfile: Dockerfile + ignore: DL3008,DL3018,DL3020,DL3029,DL3059,DL4006,DL4001,DL3006,DL3003,SC2016 + failure-threshold: warning + - + name: Validate JSON and YML files + uses: GrantBirki/json-yaml-validate@v5.0.0 From d461a21a17c2bf88ba800180fd0e1a1acb9618f1 Mon Sep 17 00:00:00 2001 From: Kroese Date: Mon, 20 Jul 2026 15:05:57 +0200 Subject: [PATCH 2/2] Update entrypoint.sh --- src/entrypoint.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/entrypoint.sh b/src/entrypoint.sh index 364dc2b..3a40d21 100644 --- a/src/entrypoint.sh +++ b/src/entrypoint.sh @@ -362,13 +362,14 @@ supercronic -quiet -no-reap /docker.cron & CRON_PID="$!" wait_process_alive "$CRON_PID" "supercronic" 1 || : -# Trap helper. _trap() { local func="$1"; shift local sig TRAP_PID="$BASHPID" for sig; do + # Capture the local callback and signal while registering the trap. + # shellcheck disable=SC2064 trap "$func $sig" "$sig" done