From b86b50126a5c17bb0d0bb3d1fc4c98ef4f9c23b8 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sat, 15 Oct 2022 00:34:03 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- gan/dataset.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/gan/dataset.py b/gan/dataset.py index caa2962..b847a49 100644 --- a/gan/dataset.py +++ b/gan/dataset.py @@ -85,7 +85,26 @@ def prepare_cartoon(data_dir, tar_filename): logger.info("Extracting cartoon tarfile") with tarfile.open(tar_filename) as f: - f.extractall(extract_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, extract_dir) path = pathlib.Path(extract_dir) logger.info("Saving images")