Forward enum deserializing does not work with collection types

[vshashi01]

#[derive(Debug, FromXml, PartialEq, ToXml)]
#[xml(forward)]
enum FooCollection {
    Bar(Vec<Bar>),
    Baz(Vec<Baz>),
}

#[derive(Debug, FromXml, PartialEq, ToXml)]
struct CollectionOwner {
    collection: FooCollection,
}

#[test]
fn wrapped_enum_collection() {
    let v = CollectionOwner {
        collection: FooCollection::Bar(vec![Bar { bar: 42 }, Bar { bar: 56 }]),
    };
    let xml =
        r#"<CollectionOwner><Bar><bar>42</bar></Bar><Bar><bar>56</bar></Bar></CollectionOwner>"#;
    assert_eq!(xml, to_string(&v).unwrap()); //this produces the expected result
    assert_eq!(v, from_str(xml).unwrap()); //this fails because only the first bar element is deserialized
}

I can help to fix this as well, however its not super clear to me where exactly the fix shall be? Should the macro generated deserialize_forward_enum account for this or the from_str implementation itself should account for multiple element case?

[djc]

I can help to fix this as well, however its not super clear to me where exactly the fix shall be? Should the macro generated deserialize_forward_enum account for this or the from_str implementation itself should account for multiple element case?

I don't really know either from the top of my head. Feel free to make a proposal for whatever you think looks cleaner? Which from_str() impl do you think should changed?

[vshashi01]

I am sorry I understood the deserializing flow wrongly hence I thought I could somehow fix it in the from_str function. That is not the case.

After looking at it forawhile I dont seem to have a single solution as well. The most obvious fix I tried was to try to fix it by looping and consuming the next element in the deserialize_forward_enum macro, but this has a problem where a non matching element is found it is already consumed and is missed by the parent element altogether.

So my guess to improve this somehow there needs to be logic update the deserialize_forward_enum and deserialize_struct.