The results from EPP operations do not implement `ToXml`

[kmkaplan]

For example domain::create::CreateData implements FromXml but does not implement ToXml. I tried deriving it and it just works. Can I submit a pull request for all of these?

[djc]

Not all of them will work due to lifetimes etc. Why do you need this?

[kmkaplan]

I want to save a copy of the results.
Edit: it is also useful server side.

[djc]

Okay, feel free to implement all of them. I guess adding the missing ToXml derives is probably straightforward, it's adding missing FromXml derives that might be trickier.

[djc]

BTW, another, potentially better approach might be to expose an API to get the original XML from the response before it was decoded. IIRC all of our response type are DeserializeOwned anyway, so we can somehow yield the XML String to the caller along with the deserialized response, to avoid reserializing it?

[kmkaplan]

Exposing the original XML sounds like a good idea for some form of data escrow, logging, debugging, etc.

But my current need is somewhat different: I want to cache the domain creation response data. Of course, what you propose would enable it. But it looks not nicely fitted.

Additionally I think it would be usefull that we can serialize what we deserialize and also deserialize what we serialize. If/when I come to EPP server side programming that would be required.

[djc]

But my current need is somewhat different: I want to cache the domain creation response data. Of course, what you propose would enable it. But I it looks not nicely fitted.

Why wouldn't it be nicely fitted?

Additionally I think it would be usefull that we can serialize what we deserialize and also deserialize what we serialize. If/when I come to EPP server side programming that would be required.

That's fair. Do you have concrete plans for building a server side? What is your use case, anyway?

[kmkaplan]

Why wouldn't it be nicely fitted?

Because it stores spurious information, that is everything else than the domain name, creation date and expiry date. That's not a serious problem though, I can live with that.

That's fair. Do you have concrete plans for building a server side?

No.

What is your use case, anyway?

I'm working on a robot that exercises our server. The aim is to have a development environment that has similar traffic to the production server.

[djc]

Because it stores spurious information, that is everything else than the domain name, creation date and expiry date. That's not a serious problem though, I can live with that.

Ah, so you want to store just the core information, not all the wrapping stuff. Okay, I'll propose that you just add ToXml derives to everywhere you need it for now, can always follow up with more changes as necessary.

[kmkaplan]

Ah, so you want to store just the core information, not all the wrapping stuff. Okay, I'll propose that you just add ToXml derives to everywhere you need it for now, can always follow up with more changes as necessary.

Exactly. I now see that I was not fully clear in my initial description. Sorry for the errance.