Skip to content

Fix Axum graceful shutdown #2262

Description

@jcjones

Without this, we lose the waiting part of graceful shutdown, and we might shut down the process while a queue job is still in flight. We could replace CloneCounterObserver with tokio_util::task::TaskTracker I think, but we'd have to change how we structure our work into Tokio tasks, and maybe replace our existing use of JoinSet. This would probably be a good thing to punt to a dedicated follow-up PR.

Originally posted by @divergentdave in #2251 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions