From 6f6f990adf223b3700e41c2df73da9f14079907a Mon Sep 17 00:00:00 2001 From: maddie-broxup Date: Mon, 7 Jul 2025 12:15:07 +0100 Subject: [PATCH 1/4] Update confirmation.html Content tweaks to reflect new service name --- src/views/submit/confirmation.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/views/submit/confirmation.html b/src/views/submit/confirmation.html index 851f2edb2..dac855a55 100644 --- a/src/views/submit/confirmation.html +++ b/src/views/submit/confirmation.html @@ -3,8 +3,8 @@ {% from "govuk/components/panel/macro.njk" import govukPanel %} -{% set serviceType = 'Submit' %} -{% set pageName = (values['dataset'] | datasetSlugToReadableName) + " submitted" %} +{% set serviceType = 'Provide' %} +{% set pageName = (values['dataset'] | datasetSlugToReadableName) + " provided" %} {% block content %} From 95c6f139891a07ab5bc030e7b4683b88a756ba76 Mon Sep 17 00:00:00 2001 From: stevenjmesser Date: Mon, 7 Jul 2025 12:57:18 +0100 Subject: [PATCH 2/4] Update confirmationPage.test.js --- test/unit/endpointSubmissionForm/confirmationPage.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/unit/endpointSubmissionForm/confirmationPage.test.js b/test/unit/endpointSubmissionForm/confirmationPage.test.js index be6b5b192..db59c53e1 100644 --- a/test/unit/endpointSubmissionForm/confirmationPage.test.js +++ b/test/unit/endpointSubmissionForm/confirmationPage.test.js @@ -17,11 +17,11 @@ describe('Submit confirmation View', () => { const html = stripWhitespace(nunjucks.render('submit/confirmation.html', params)) runGenericPageTests(html, { - pageTitle: 'mockDataset submitted - Submit your planning data' + pageTitle: 'mockDataset provided - Submit your planning data' }) it('should render the gov uk panel', () => { - const regex = new RegExp('

', 'g') + const regex = new RegExp('

', 'g') expect(html).toMatch(regex) }) From 6393d192e77d32690580a4945aeb5ee82cd66932 Mon Sep 17 00:00:00 2001 From: stevenjmesser Date: Mon, 7 Jul 2025 13:28:01 +0100 Subject: [PATCH 3/4] Update confirmationPage.test.js --- test/unit/endpointSubmissionForm/confirmationPage.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/endpointSubmissionForm/confirmationPage.test.js b/test/unit/endpointSubmissionForm/confirmationPage.test.js index db59c53e1..1cc918f04 100644 --- a/test/unit/endpointSubmissionForm/confirmationPage.test.js +++ b/test/unit/endpointSubmissionForm/confirmationPage.test.js @@ -17,7 +17,7 @@ describe('Submit confirmation View', () => { const html = stripWhitespace(nunjucks.render('submit/confirmation.html', params)) runGenericPageTests(html, { - pageTitle: 'mockDataset provided - Submit your planning data' + pageTitle: 'mockDataset provided - Provide your planning data' }) it('should render the gov uk panel', () => { From 37b920f070ad13cf9890865b8478c59efa7262d0 Mon Sep 17 00:00:00 2001 From: stevenjmesser Date: Mon, 7 Jul 2025 17:06:57 +0000 Subject: [PATCH 4/4] Update serviceNames key and tests --- config/default.yaml | 2 +- src/views/submit/confirmation.html | 2 +- test/unit/endpointSubmissionForm/confirmationPage.test.js | 2 +- test/unit/views/submit/check-answers.test.js | 2 +- test/unit/views/submit/choose-datasetPage.test.js | 2 +- test/unit/views/submit/dataset-details.test.js | 2 +- test/unit/views/submit/lpa-detailsPage.test.js | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/config/default.yaml b/config/default.yaml index db5a2144b..2bfe496e1 100644 --- a/config/default.yaml +++ b/config/default.yaml @@ -22,7 +22,7 @@ dataDesignUrl: https://design.planning.data.gov.uk serviceName: 'Check and provide planning data' # NOTE: the keys in this map are sometimes referred to as "serviceType" in the templates serviceNames: { - submit: 'Submit your planning data', + submit: 'Check and provide your planning data', check: 'Check your planning data', manage: 'Check and provide planning data' } diff --git a/src/views/submit/confirmation.html b/src/views/submit/confirmation.html index dac855a55..3a5eac937 100644 --- a/src/views/submit/confirmation.html +++ b/src/views/submit/confirmation.html @@ -3,7 +3,7 @@ {% from "govuk/components/panel/macro.njk" import govukPanel %} -{% set serviceType = 'Provide' %} +{% set serviceType = 'Submit' %} {% set pageName = (values['dataset'] | datasetSlugToReadableName) + " provided" %} {% block content %} diff --git a/test/unit/endpointSubmissionForm/confirmationPage.test.js b/test/unit/endpointSubmissionForm/confirmationPage.test.js index 1cc918f04..a83fea55a 100644 --- a/test/unit/endpointSubmissionForm/confirmationPage.test.js +++ b/test/unit/endpointSubmissionForm/confirmationPage.test.js @@ -17,7 +17,7 @@ describe('Submit confirmation View', () => { const html = stripWhitespace(nunjucks.render('submit/confirmation.html', params)) runGenericPageTests(html, { - pageTitle: 'mockDataset provided - Provide your planning data' + pageTitle: 'mockDataset provided - Check and provide your planning data' }) it('should render the gov uk panel', () => { diff --git a/test/unit/views/submit/check-answers.test.js b/test/unit/views/submit/check-answers.test.js index c551302ec..106839016 100644 --- a/test/unit/views/submit/check-answers.test.js +++ b/test/unit/views/submit/check-answers.test.js @@ -21,7 +21,7 @@ describe('check-answers View', async () => { const html = stripWhitespace(nunjucks.render('check-answers.html', params)) runGenericPageTests(html, { - pageTitle: 'Check your answers - Submit your planning data' + pageTitle: 'Check your answers - Check and provide your planning data' }) it('should render the lpa selected', () => { diff --git a/test/unit/views/submit/choose-datasetPage.test.js b/test/unit/views/submit/choose-datasetPage.test.js index a2fd07b87..38ef4cea1 100644 --- a/test/unit/views/submit/choose-datasetPage.test.js +++ b/test/unit/views/submit/choose-datasetPage.test.js @@ -12,7 +12,7 @@ describe('choose dataset View', () => { const html = nunjucks.render('choose-dataset.html', params) runGenericPageTests(html, { - pageTitle: 'Choose dataset - Submit your planning data' + pageTitle: 'Choose dataset - Check and provide your planning data' }) it('should display an error message when the dataset field is empty', () => { diff --git a/test/unit/views/submit/dataset-details.test.js b/test/unit/views/submit/dataset-details.test.js index b93e4d429..c12574879 100644 --- a/test/unit/views/submit/dataset-details.test.js +++ b/test/unit/views/submit/dataset-details.test.js @@ -48,7 +48,7 @@ describe(`dataset details View (seed: ${seed})`, () => { const html = stripWhitespace(nunjucks.render('dataset-details.html', params)) runGenericPageTests(html, { - pageTitle: 'Endpoint details - Submit your planning data' + pageTitle: 'Endpoint details - Check and provide your planning data' }) it('should render the correct header', () => { diff --git a/test/unit/views/submit/lpa-detailsPage.test.js b/test/unit/views/submit/lpa-detailsPage.test.js index b7727a2c8..9892a70d9 100644 --- a/test/unit/views/submit/lpa-detailsPage.test.js +++ b/test/unit/views/submit/lpa-detailsPage.test.js @@ -12,7 +12,7 @@ describe('Lpa-details View', () => { const htmlNoErrors = nunjucks.render('lpa-details.html', params) runGenericPageTests(htmlNoErrors, { - pageTitle: 'What are your contact details? - Submit your planning data' + pageTitle: 'What are your contact details? - Check and provide your planning data' }) describe('validation errors', () => {