hard-coded hiera settings?

[p4t0k]

Hi, if I read your code correctly, there are hardcoded values from hiera in templates... omg this is so wrong.... what if I need to define for example hostrelay in puppet class?

for example having customized hiera config:

custom::postfix::package_ensure: 'latest'
custom::postfix::relayhost: 'smtp1.prod.cnc'

and defined class for it:

class custom::postfix ($package_ensure, $relayhost) {
 
    class { 'postfix':
            package_ensure => $package_ensure,
            relayhost      => 'smtp1.prod.cnc',
    }
}

but this doesn't work because your module expects only one exact hiera structure and even it uses class parameters with it's default values it never uses them in erb templates! this could be quite nice, almost dependency free module, but this really sucks :-(
Please, make it more flexible by using internal variables which you already have defined.