Symlink in Python source breaks `maturin pep517 build-wheel`

[gadomski]

Discovered while working conda-forge/staged-recipes#32441. Demonstration:

$ curl https://github.com/developmentseed/async-tiff/archive/refs/tags/py-v0.7.0.tar.gz -O -L
$ tar xvzf py-v0.7.0.tar.gz
$ cd async-tiff-py-v0.7.0/python
$ maturin pep517 build-wheel --compatibility off

You should end up with:

    Finished `release` profile [optimized] target(s) in 1m 10s
💥 maturin failed
  Caused by: Failed to add the files to the wheel
  Caused by: Failed to add the python module to the package
  Caused by: No such file or directory (os error 2)

UPDATE: I have the same setup in rustac (with the symlink), but my source on PyPI contains the files from the symlink (e.g. https://pypi.org/project/rustac/#rustac-0.9.8.tar.gz). So the downstream issue could be resolved by #272 and then using that on conda-forge.

[kylebarron]

Ah, thanks for finding this.

Q1: does the symlink resolve in that bundle outside of maturin? I.e. if you use ls can it traverse the symlink? If so, perhaps this is a bug report we should make in maturin.

I'm happy to have #272

[gadomski]

Q1: does the symlink resolve in that bundle outside of maturin? I.e. if you use ls can it traverse the symlink? If so, perhaps this is a bug report we should make in maturin.

In this case, there's nothing to resolve to — the tarball at https://github.com/developmentseed/async-tiff/archive/refs/tags/py-v0.7.0.tar.gz has nothing at async-tiff-py-v0.7.0/python/_obstore.

[kylebarron]

Q1: does the symlink resolve in that bundle outside of maturin? I.e. if you use ls can it traverse the symlink? If so, perhaps this is a bug report we should make in maturin.

In this case, there's nothing to resolve to — the tarball at refs/tags/py-v0.7.0.tar.gz has nothing at async-tiff-py-v0.7.0/python/_obstore.

Oh I see; it's like we need a git submodule update from the sdist

I made #277

[kylebarron]

I think this is closed by #277