The dask_image.ndinterp.rotate function currently supports numpy backed dask arrays, but not cupy GPU arrays. It would be nice to extend the functionality to add GPU support.
Suggested approach:
One way to approach this could be to:
- Try and split out the sub-section of the
rotate function that makes the rotation matrix, and put this into a separate helper function (i.e. group all the numpy specific lines of code together, while keeping the function as small as possible to reduce code duplication later).
- Make a second version of the helper function using cupy/cupyx functions replacing all the lines that call numpy directly.
- Then we could use the same dispatch mechanism as we do with the other modules (see the dask_image/dispatch folder) to register our new numpy and cupy versions.
- Add a test for the new functionality
- Update the
coverage.rst table, adding a tick mark to indicate this function now has GPU support
The
dask_image.ndinterp.rotatefunction currently supports numpy backed dask arrays, but not cupy GPU arrays. It would be nice to extend the functionality to add GPU support.Suggested approach:
One way to approach this could be to:
rotatefunction that makes the rotation matrix, and put this into a separate helper function (i.e. group all the numpy specific lines of code together, while keeping the function as small as possible to reduce code duplication later).coverage.rsttable, adding a tick mark to indicate this function now has GPU support