Skip to content

Errors in revision a03ba22 #13

Description

@haleyjd

There are three problems in revision a03ba22 to remove the deprecated usage of wfMsg* functions:

  • Monaco.skin.php at line 545: Syntax is incorrect here, the ->text() call needs to be moved outside the parens.
  • Monaco.skin.php at line 1093: Need to use wfMessage()->rawParams()->text() to get equivalent logic to wfMsgHtml here, because the output is an argument to Html::rawElement, which expects unescaped arguments.
  • Monaco.skin.php at line 1111: Need to use wfMessage()->rawParams()->escaped() to get equivalent logic to wfMsgHtml, but here the output goes directly to the page so the escaping is appropriate.

See haleyjd/monaco-port@f26ad47 and haleyjd/monaco-port@6708eb0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions