Skip to content

[v0.91.8][WP-20][csdlc-v2][tests] Initialize Gate 2 temp roots before terminal recovery #5548

Description

@danielbaustin

Problem

The full cargo test --locked run while validating #5527 reports 26 failures in csdlc-v2/tests/gate2.rs. Each failing fixture reaches store initialization in a temporary root that is not a Git repository, then terminal-recovery setup invokes:

git rev-parse --path-format=absolute --git-common-dir

The command fails with fatal: not a git repository. This prevents the Gate 2 suite from reaching the behavior each test is intended to exercise.

Evidence

Required outcome

Choose the architecture-correct repair:

  1. initialize Gate 2 fixture roots as minimal Git repositories before constructing the store, or
  2. defer Git-common-dir terminal receipt discovery when initializing a nonterminal store that does not require terminal recovery.

Do not weaken the terminal receipt/common-directory invariants for real repositories.

Acceptance criteria

  • All Gate 2 tests reach their intended assertions and pass.
  • cargo test --locked passes for csdlc-v2.
  • Terminal receipt recovery still resolves the real repository common directory and remains fail-closed.
  • Add or retain a regression proving non-Git fixture behavior explicitly.
  • No AWS dependency or validation.

Scope

This was discovered during #5527 validation but is not caused by the bounded terminal SOR artifact-reference repair. Track and repair it independently.

v0.91.8 Routing Correction

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:reviewReview and triage worktrack:roadmapRoadmap-level worktype:bugBug or correctness issueversion:v0.91.8ADL v0.91.8 milestone scopewp:WP-20v0.91.5 work package 20 ordering label

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions