[BUG] Typescript 7.0.2

[clates]

Describe the bug

Typescript 7.0.2 is the latest available typescript package in npm and gets installed during

https://github.com/danger/danger-js/blob/13.0.10/Dockerfile#L16

It does not support getDefaultCompilerOptions as used in
https://github.com/danger/danger-js/blob/13.0.10/source/runner/runners/utils/transpiler.ts#L130-L132

To Reproduce
Steps to reproduce the behavior:

1. Run danger.js and attempt to transpile without overriding the default compiler options.

Additional context
Add any other context about the problem here.

Suspect that

RUN yarn remove 'typescript' --dev && yarn add 'typescript@6.0.3'

Would be sufficient until support for 7.x.x is both stable on the provider side and in danger-js

[clates]

I think this is a minimal repro: https://github.com/clates/danger-ts-bug

With a failing run:
https://github.com/clates/danger-ts-bug/actions/runs/28969914746/job/85962669189?pr=1

Log

Run danger/danger-js@13.0.10
Error:  TypeError: ts.getDefaultCompilerOptions is not a function
    at typescriptify (/usr/src/danger/dist/runner/runners/utils/transpiler.js:158:30)
    at /usr/src/danger/dist/runner/runners/utils/transpiler.js:235:44
    at /usr/src/danger/dist/runner/runners/inline.js:154:53
    at step (/usr/src/danger/dist/runner/runners/inline.js:56:23)
    at Object.next (/usr/src/danger/dist/runner/runners/inline.js:37:53)
    at /usr/src/danger/dist/runner/runners/inline.js:31:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/src/danger/dist/runner/runners/inline.js:27:12)
    at runDangerfileEnvironment (/usr/src/danger/dist/runner/runners/inline.js:123:132)
    at /usr/src/danger/dist/platforms/GitHub.js:181:38
Failing the build, there is 1 fail.
Feedback: https://github.com/clates/danger-ts-bug/pull/1#issuecomment-4918478692
Could not add a commit status, the GitHub token for Danger does not have access rights.
If the build fails, then danger will use a failing exit code.

With the fix in #1522

clates/danger-ts-bug#2

[fbartho]

I suspect we want to express typescript as < 7.0.0 instead of locking ourselves to specifically 6.0.3?

[fbartho]

An alternative approach would be to import the side-by-side compatibility package for using TS7 as the runtime, but TS6 compiler APIs?

https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0

[clates]

I suspect we want to express typescript as < 7.0.0 instead of locking ourselves to specifically 6.0.3?

Dealer's choice 👍

I don't have any context on if TS >7.1.x will retain the getDefaultCompilerOptions from 6.0.3, so not sure if you were going to plan on a comprehensive update to support 7.1.x.
Figured you'd want to get a stopgap in quick as this is going to be "broken" in all repos using danger-js at the moment.

Totally up to you how you'd like to proceed - feel free to commit on top of / req changes / close #1522

[orta]

I doubt it will support the same APIs for sure, I think we can probably just hardcode that function - defaults did change in 7 but maybe not for things that this affects

the 'real' issue is that we re-use typescript for transpilation here and that API won't be available either. I had wanted to avoid a dependency for that, but at this point we could probably use something simple like sucrase which 'just works' for the transpiling

[G-Rath]

fwiw we've started having failures over at eslint-plugin-jest which I assume is for the same reason, even though the function is ts.transpileModule which is called next:

Error:  TypeError: ts.transpileModule is not a function
    at typescriptify (/usr/src/danger/dist/runner/runners/utils/transpiler.js:160:21)
    at /usr/src/danger/dist/runner/runners/utils/transpiler.js:235:44
    at /usr/src/danger/dist/runner/runners/inline.js:154:53
    at step (/usr/src/danger/dist/runner/runners/inline.js:56:23)
    at Object.next (/usr/src/danger/dist/runner/runners/inline.js:37:53)
    at /usr/src/danger/dist/runner/runners/inline.js:31:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/src/danger/dist/runner/runners/inline.js:27:12)
    at runDangerfileEnvironment (/usr/src/danger/dist/runner/runners/inline.js:123:132)
    at /usr/src/danger/dist/platforms/GitHub.js:181:38
danger-results://tmp/danger-results-ddcd91b7.json

Mainly posting this comment for the search keywords 🙂