Skip to content

Conservative residual norm factors #46

Description

@cwentland0

When solving for the conservative variables with an implicit time integrator (dual_time = False), the various residual fields are still normalized by res_norm_prim. Of course, this is not accurate and comparative conservative normalization factors should be used. I think the simplest way to go about this is to still take in user input for res_norm_prim (or rely on RES_NORM_PRIM_DEFAULT) and compute the equivalent conservative state. This can then be used for normalizing the conservative residual norms. I figure this is easier because people don't really think in terms of the conservative variables, and initial conditions are provided in terms of the primitive state.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions