Security/plugin hardening

[pontusab]

Note

High Risk
Changes affect plugin install payloads, repository pinning, security rescans, and star-count integrity via a new SECURITY DEFINER RPC—areas that directly impact user trust and marketplace data correctness.

Overview
Hardens plugin create, update, star, and detail flows against trust and install-safety issues.

Create resolves github_repo_id server-side from the repository URL (GitHub API) instead of trusting the client, then passes it into insertPlugin for idempotent repo identity.

Update locks the repository URL when github_repo_id is set, fingerprints only install-relevant component fields (content/metadata/repository), deactivates and resets scan flags when those change, and enqueues rescans only when needed. The edit form mirrors the lock in the UI.

Stars replace the multi-step admin/user split with a single toggle_plugin_star RPC on the user-scoped Supabase client; a migration adds a unique (plugin_id, user_id) constraint, serializes toggles, recomputes star_count from plugin_stars, and drops the old increment/decrement helpers.

Plugin detail URL-encodes MCP install deeplink base64, hides one-click install when the plugin is inactive (content still visible), and expands MCP rows with a config preview before install.

GitHub parse exports resolveGithubRepoIdFromRepository for the create path.

^{Reviewed by Cursor Bugbot for commit 1ccb658. Bugbot is set up for automated code reviews on this repo. Configure here.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cursor-directory	Ready	Preview, Comment	May 24, 2026 6:14pm

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Metadata changes skip rescan
  • Component fingerprints now include the effective saved metadata so install-relevant MCP metadata updates trigger a rescan.

Or push these changes by commenting:

@cursor push 8f1c1185c3

Preview (8f1c1185c3)

diff --git a/apps/cursor/src/actions/update-plugin.ts b/apps/cursor/src/actions/update-plugin.ts
--- a/apps/cursor/src/actions/update-plugin.ts
+++ b/apps/cursor/src/actions/update-plugin.ts
@@ -48,19 +48,21 @@
 }
 
 // Only fields that affect the install payload — cosmetic edits to name,
-// description, sort_order, or metadata must not trigger a rescan. The edit
-// form does not surface metadata (GitHub imports store MCP config there).
+// description, or sort_order must not trigger a rescan. MCP install links and
+// configs can live in metadata, so compare the metadata that will be saved.
 function fingerprintComponent(c: {
   type: string;
   slug?: string | null;
   name: string;
   content?: string | null;
+  metadata?: Record<string, unknown> | null;
 }): string {
   const slug = c.slug || slugify(c.name);
   return JSON.stringify({
     type: c.type,
     slug,
     content: c.content ?? "",
+    metadata: c.metadata ?? {},
   });
 }
 
@@ -95,7 +97,20 @@
     .sort((a, b) => a.sort_order - b.sort_order)
     .map(fingerprintComponent)
     .sort();
-  const nextSorted = nextComponents.map(fingerprintComponent).sort();
+  const prevByKey = new Map(
+    prevComponents.map((c) => [
+      componentKey(c.type, c.slug || slugify(c.name)),
+      c,
+    ]),
+  );
+  const nextSorted = nextComponents
+    .map((component) =>
+      fingerprintComponent({
+        ...component,
+        metadata: resolveComponentMetadata(component, prevByKey),
+      }),
+    )
+    .sort();
 
   for (let i = 0; i < prevSorted.length; i++) {
     if (prevSorted[i] !== nextSorted[i]) return true;

_{You can send follow-ups to the cloud agent here.}

[leerob]

@cursor push 8f1c118

[leerob]

@cursor fix this too

./src/actions/update-plugin.ts:262:58
Type error: Cannot find name 'queueError'.
  260 |           kickDrainAfterResponse();
  261 |         } catch (workflowError) {
> 262 |           console.error("Failed to enqueue plugin scan", queueError);
      |                                                          ^
  263 |         }
  264 |       }

[cursor]

Fixed the type error in update-plugin.ts: the catch block bound workflowError but logged queueError. The handler now uses queueError in both places, matching insert.ts.

Change is committed and pushed to security/plugin-hardening on PR #393.

  

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Delist before components saved
  • Plugin updates and component rewrites now run through an atomic database function so delist/reset changes roll back if component replacement fails.
• ✅ Fixed: Scan quota on cosmetic edits
  • The plugin scan rate limit now runs only when an install-relevant change will actually enqueue a rescan.

Or push these changes by commenting:

@cursor push 7fc3405725

Preview (7fc3405725)

diff --git a/apps/cursor/src/actions/update-plugin.ts b/apps/cursor/src/actions/update-plugin.ts
--- a/apps/cursor/src/actions/update-plugin.ts
+++ b/apps/cursor/src/actions/update-plugin.ts
@@ -172,13 +172,6 @@
         );
       }
 
-      const { success } = await pluginScanLimit(userId);
-      if (!success) {
-        throw new ActionError(
-          "Too many plugin updates in the last hour. Please try again later.",
-        );
-      }
-
       // Source URL is pinned to the parsed GitHub repo so an owner can't keep
       // the verified-looking badge while swapping the install payload.
       const repositoryLocked = existing.github_repo_id != null;
@@ -197,51 +190,15 @@
       );
 
       const shouldRescan = installChanged;
-      const updatePayload: Record<string, unknown> = {
-        name,
-        description,
-        logo: logo || null,
-        repository: effectiveRepository,
-        homepage: homepage || null,
-        keywords: keywords || [],
-      };
-
-      if (shouldRescan && existing.active) {
-        updatePayload.active = false;
-        updatePayload.scan_status = "pending";
-        updatePayload.flag_summary = null;
-        updatePayload.flag_reasons = [];
-        updatePayload.flag_severity = null;
-        updatePayload.flagged_at = null;
-      }
-
-      const { error: updateError } = await supabase
-        .from("plugins")
-        .update(updatePayload)
-        .eq("id", id);
-
-      if (updateError) {
-        if (updateError.code === "23505") {
+      if (shouldRescan) {
+        const { success } = await pluginScanLimit(userId);
+        if (!success) {
           throw new ActionError(
-            "A plugin with this name already exists. Please choose a different name.",
+            "Too many plugin updates in the last hour. Please try again later.",
           );
         }
-        throw new ActionError(
-          `Failed to update plugin: ${updateError.message}`,
-        );
       }
 
-      const { error: deleteError } = await supabase
-        .from("plugin_components")
-        .delete()
-        .eq("plugin_id", id);
-
-      if (deleteError) {
-        throw new ActionError(
-          `Failed to update components: ${deleteError.message}`,
-        );
-      }
-
       const prevByKey = new Map(
         prevComponents.map((c) => [
           componentKey(c.type, c.slug || slugify(c.name)),
@@ -260,15 +217,32 @@
         sort_order: i,
       }));
 
-      const { error: compError } = await supabase
-        .from("plugin_components")
-        .insert(componentRows);
+      const { error: updateError } = await supabase.rpc(
+        "update_plugin_with_components",
+        {
+          p_plugin_id: id,
+          p_name: name,
+          p_description: description,
+          p_logo: logo || null,
+          p_repository: effectiveRepository,
+          p_homepage: homepage || null,
+          p_keywords: keywords || [],
+          p_components: componentRows,
+          p_deactivate_for_scan: shouldRescan && existing.active,
+        },
+      );
 
-      if (compError) {
+      if (updateError) {
+        if (updateError.code === "23505") {
+          throw new ActionError(
+            "A plugin with this name already exists. Please choose a different name.",
+          );
+        }
         throw new ActionError(
-          `Failed to save plugin components: ${compError.message}`,
+          `Failed to update plugin: ${updateError.message}`,
         );
       }
+
       if (shouldRescan) {
         try {
           await enqueuePluginScan(id);

diff --git a/supabase/migrations/20260524_atomic_plugin_update.sql b/supabase/migrations/20260524_atomic_plugin_update.sql
new file mode 100644
--- /dev/null
+++ b/supabase/migrations/20260524_atomic_plugin_update.sql
@@ -1,0 +1,85 @@
+-- Keep plugin metadata updates and component rewrites in a single transaction.
+-- If a component row fails validation, Postgres rolls back the delist/reset too.
+create or replace function public.update_plugin_with_components(
+  p_plugin_id uuid,
+  p_name text,
+  p_description text,
+  p_logo text,
+  p_repository text,
+  p_homepage text,
+  p_keywords text[],
+  p_components jsonb,
+  p_deactivate_for_scan boolean
+)
+returns void
+language plpgsql
+set search_path = public
+as $$
+begin
+  update public.plugins
+  set
+    name = p_name,
+    description = p_description,
+    logo = p_logo,
+    repository = p_repository,
+    homepage = p_homepage,
+    keywords = coalesce(p_keywords, '{}'::text[]),
+    active = case when p_deactivate_for_scan then false else active end,
+    scan_status = case
+      when p_deactivate_for_scan then 'pending'
+      else scan_status
+    end,
+    flag_summary = case when p_deactivate_for_scan then null else flag_summary end,
+    flag_reasons = case
+      when p_deactivate_for_scan then '{}'::text[]
+      else flag_reasons
+    end,
+    flag_severity = case when p_deactivate_for_scan then null else flag_severity end,
+    flagged_at = case when p_deactivate_for_scan then null else flagged_at end
+  where id = p_plugin_id;
+
+  if not found then
+    raise exception 'plugin not found'
+      using errcode = 'P0002';
+  end if;
+
+  delete from public.plugin_components
+  where plugin_id = p_plugin_id;
+
+  insert into public.plugin_components (
+    plugin_id,
+    type,
+    name,
+    slug,
+    description,
+    content,
+    metadata,
+    sort_order
+  )
+  select
+    p_plugin_id,
+    component.type,
+    component.name,
+    component.slug,
+    component.description,
+    component.content,
+    coalesce(component.metadata, '{}'::jsonb),
+    component.sort_order
+  from jsonb_to_recordset(p_components) as component(
+    type text,
+    name text,
+    slug text,
+    description text,
+    content text,
+    metadata jsonb,
+    sort_order integer
+  );
+end;
+$$;
+
+revoke execute on function public.update_plugin_with_components(
+  uuid, text, text, text, text, text, text[], jsonb, boolean
+) from public, anon, authenticated;
+grant execute on function public.update_plugin_with_components(
+  uuid, text, text, text, text, text, text[], jsonb, boolean
+) to service_role;

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 1ccb658. Configure here.}

[cursor]

Delist before components saved

High Severity · Logic Bug

When an install-relevant edit runs on an active plugin, the row is set active=false and scan fields reset before components are deleted and re-inserted. If the component insert fails after the delete succeeds, the plugin stays delisted with no components, even though the action returns an error.

 

^{Reviewed by Cursor Bugbot for commit 1ccb658. Configure here.}

[cursor]

Scan quota on cosmetic edits

Medium Severity · Logic Bug

pluginScanLimit (5/hour per user per firewall config) still runs on every update before shouldRescan is computed. Cosmetic-only saves no longer enqueue scans, but they still consume the scan rate limit and can block further edits with “Too many plugin updates in the last hour.”

 

^{Reviewed by Cursor Bugbot for commit 1ccb658. Configure here.}