Support Jest (commonjs)

[hollandjake]

Would it be possible to add support for commonjs?

Having issues using this with jest due to the import statements

[hildjj]

As long as you're on node 20+ (which is all that is supported), you should be able to just use require and have it work, since there is no async code at the root level.

[hollandjake]

Unfortunately you cannot require a esm module package. It would have to have a commonjs export to enable that (see PR #17).

For context I'm trying to use this module in the PDFKit project, this runs on esm but is transpiled into esm and commonjs. The tests using jest also run in commonjs because jest doesn't support esm, and its having issues with the import statements in your module for some reason it is unable to transpile it.

[hollandjake]

Another option is to convert this project (and the unicode-trie) into commonjs native (although I also agree modules are much better). Im investigating as to whether I can move PDFKit off of jest because its lack of ESM support is shocking

[hollandjake]

I've managed to migrate over to vitest so ESM support is by default, feel free to close this if you wish to stay as an ESM only package

[hildjj]

Node 20 added the ability to require an esm module. Give it a try.

[hollandjake]

I think the issue is to do with jest as you are right I was able to run it in node natively

[hildjj]

That makes sense! I only use Jest on one project, and it's nothing but slow trouble. I'm going to rename this as "Support Jest", and re-open it.

[hildjj]

This is likely to stay open until someone actually needs it. Please comment here if you can't move off of Jest.

[hollandjake]

As an fyi for others, can confirm this works fine in vitest

[hildjj]

Thanks @hollandjake for tracking this all the way down for us!
(should have said that earlier, sorry)