Skip to content

Code does not work #1

Description

@rfali

While I highly appreciate the authors of the paper to have made the code available, and a very lengthy ReadMe file to go with it, unfortunately it does not work as intended. Some suggestions

  1. The Heart Disease dataset should be included in the repo (it is after all public).
  2. The Hypertenstion dataset is not included, and as such the code associated with it should have been removed (or the dataset included).
  3. The file structure is not correct. The files have been moved into src directory but the figure1.py cannot access the necessary imports. Necessary changes like:
    import src.hierarchyrl.powerset, src.hierarchyrl.utils, src.hierarchyrl.policy2
  4. Readme mentions that pkl files have been included or provided, but that is not the case.
  5. I was able to produce Fig1 but it was not "reproduced" i.e. the image was different from the one in paper, while using the default settings.

I would highly suggest the authors/developers to be a little more prudent while making public their research. While the code is definitely welcome, it should be tested before made public.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions