From ab479106db9383d9543db496019590408eb043e8 Mon Sep 17 00:00:00 2001 From: kwood <155027796+qkewq@users.noreply.github.com> Date: Tue, 14 Jul 2026 15:49:10 -0700 Subject: [PATCH 1/3] Make future pool names start with letters - pve9 requires pools to start with a letter --- internal/proxmox/pools.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/proxmox/pools.go b/internal/proxmox/pools.go index 4ca9038..e8e8319 100644 --- a/internal/proxmox/pools.go +++ b/internal/proxmox/pools.go @@ -16,7 +16,7 @@ import ( func (s *ProxmoxService) GetPoolVMs(poolName string) ([]VirtualResource, error) { req := tools.ProxmoxAPIRequest{ Method: "GET", - Endpoint: fmt.Sprintf("/pools/%s", poolName), + Endpoint: fmt.Sprintf("/pools/?poolid=%s", poolName), } var poolResponse struct { @@ -92,7 +92,7 @@ func (s *ProxmoxService) SetPoolPermission(poolName string, targetName string, i func (s *ProxmoxService) DeletePool(poolName string) error { req := tools.ProxmoxAPIRequest{ Method: "DELETE", - Endpoint: fmt.Sprintf("/pools/%s", poolName), + Endpoint: fmt.Sprintf("/pools/?poolid=%s", poolName), } _, err := s.RequestHelper.MakeRequest(req) From 99d0f4c840339accc14bc448a27ccade9765e14c Mon Sep 17 00:00:00 2001 From: kwood <155027796+qkewq@users.noreply.github.com> Date: Tue, 14 Jul 2026 16:03:12 -0700 Subject: [PATCH 2/3] Make pool names start with a letter --- internal/cloning/cloning_service.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/cloning/cloning_service.go b/internal/cloning/cloning_service.go index 1bdbe91..bf959ce 100644 --- a/internal/cloning/cloning_service.go +++ b/internal/cloning/cloning_service.go @@ -146,7 +146,7 @@ func (cs *CloningService) CloneTemplate(req CloneRequest) error { } for i := range req.Targets { - req.Targets[i].PoolName = fmt.Sprintf("%s_%s_%s", podIDs[i], req.Template, req.Targets[i].Name) + req.Targets[i].PoolName = fmt.Sprintf("pod_%s_%s_%s", podIDs[i], req.Template, req.Targets[i].Name) req.Targets[i].PodID = podIDs[i] req.Targets[i].PodNumber = podNumbers[i] req.Targets[i].VMIDs = vmIDs[i*(numVMsPerTarget) : (i+1)*(numVMsPerTarget)] From 352a0517a8378377c2775592dfade15ec077b249 Mon Sep 17 00:00:00 2001 From: kwood <155027796+qkewq@users.noreply.github.com> Date: Tue, 14 Jul 2026 16:17:17 -0700 Subject: [PATCH 3/3] Revert "Make future pool names start with letters" This reverts commit ab479106db9383d9543db496019590408eb043e8. --- internal/proxmox/pools.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/proxmox/pools.go b/internal/proxmox/pools.go index e8e8319..4ca9038 100644 --- a/internal/proxmox/pools.go +++ b/internal/proxmox/pools.go @@ -16,7 +16,7 @@ import ( func (s *ProxmoxService) GetPoolVMs(poolName string) ([]VirtualResource, error) { req := tools.ProxmoxAPIRequest{ Method: "GET", - Endpoint: fmt.Sprintf("/pools/?poolid=%s", poolName), + Endpoint: fmt.Sprintf("/pools/%s", poolName), } var poolResponse struct { @@ -92,7 +92,7 @@ func (s *ProxmoxService) SetPoolPermission(poolName string, targetName string, i func (s *ProxmoxService) DeletePool(poolName string) error { req := tools.ProxmoxAPIRequest{ Method: "DELETE", - Endpoint: fmt.Sprintf("/pools/?poolid=%s", poolName), + Endpoint: fmt.Sprintf("/pools/%s", poolName), } _, err := s.RequestHelper.MakeRequest(req)