Skip to content

CBG-5367: add metadata store to dcp client for both CBS and rosmar#8279

Merged
bbrks merged 3 commits into
mainfrom
CBG-5367
May 18, 2026
Merged

CBG-5367: add metadata store to dcp client for both CBS and rosmar#8279
bbrks merged 3 commits into
mainfrom
CBG-5367

Conversation

@gregns1

@gregns1 gregns1 commented May 18, 2026

Copy link
Copy Markdown
Contributor

CBG-5367

Adds ability to pass down metadata store into dcp client for both rosmar and CBS

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Dependencies (if applicable)

Integration Tests

Copilot AI review requested due to automatic review settings May 18, 2026 14:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR wires a metadata store through DCP client setup so persistent DCP checkpoints can be stored outside the streamed collection, covering both Couchbase Server and Rosmar-backed feeds.

Changes:

  • Adds MetadataStore to DCP client option structs and forwards it to GoCB and Rosmar DCP clients.
  • Updates import, resync, attachment migration, and attachment compaction DCP option construction to pass database metadata stores.
  • Bumps sg-bucket and rosmar module versions and updates related tests.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
go.mod Updates sg-bucket and rosmar dependency versions.
go.sum Updates checksums for the bumped dependencies.
db/import_listener.go Passes database metadata store to import DCP feed options.
db/background_mgr_resync_dcp.go Passes metadata store to resync DCP options.
db/background_mgr_attachment_migration.go Threads metadata store into attachment migration DCP options.
db/background_mgr_attachment_migration_test.go Updates test helper call for the new metadata store argument.
db/attachment_compaction.go Passes metadata store to attachment compaction DCP options.
base/rosmar_dcp_client.go Forwards metadata store into Rosmar feed arguments and checkpoint purge lookup.
base/gocb_dcp_feed.go Removes obsolete GoCB DCP feed startup implementation.
base/gocb_dcp_client.go Adds persistent metadata store option to GoCB DCP client creation.
base/dcp_client.go Adds metadata store option validation and forwards it to GoCB DCP options.
base/dcp_client_test.go Updates DCP tests to provide metadata stores where persistent checkpoints are used.

Comment thread base/gocb_dcp_client.go Outdated
Comment thread base/dcp_client.go Outdated
@gregns1 gregns1 self-assigned this May 18, 2026
@bbrks bbrks merged commit f573e6f into main May 18, 2026
48 checks passed
@bbrks bbrks deleted the CBG-5367 branch May 18, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants