fix(openai-adapters): convert requestOptions.timeout from seconds to ms#12521
Open
devYRPauli wants to merge 1 commit into
Open
fix(openai-adapters): convert requestOptions.timeout from seconds to ms#12521devYRPauli wants to merge 1 commit into
devYRPauli wants to merge 1 commit into
Conversation
requestOptions.timeout is expressed in seconds throughout Continue (packages/fetch getAgentOptions multiplies by 1000), but the OpenAI SDK client received the raw value, which it treats as milliseconds. A user setting timeout: 300 got 300ms instead of 300s, causing immediate "Connection error" failures (especially with local models). Multiply by 1000 before passing to the SDK. Fixes continuedev#12450.
dosubot
Bot
added
the
size:XS
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
requestOptions.timeoutis expressed in seconds throughout Continue (e.g.packages/fetchgetAgentOptions:(timeout ?? 7200) * 1000 // ms), butpackages/openai-adapters/src/apis/OpenAI.tspassed the raw value to the OpenAI JS SDK, which interpretstimeoutas milliseconds. Sotimeout: 300(intended as 5 min) became 300ms — ~2000× too short — causing immediate "Connection error" failures, especially with local models. This multiplies by 1000 before passing to the SDK. Fixes #12450 (likely a root cause behind #11818 / #11954).Checklist
Tests
Added
src/apis/OpenAI.test.ts: asserts the OpenAI client gets300000ms whenrequestOptions.timeoutis300, and the SDK default (600000) is preserved when unset. Fullopenai-adapterssuite passes (147 tests);tsc+ Prettier clean.Summary by cubic
Fix timeout unit mismatch in
packages/openai-adapters: convertrequestOptions.timeout(seconds) to milliseconds before creating the OpenAI SDK client. Prevents 300s configs being treated as 300ms and avoids instant connection errors, especially with local models.requestOptions.timeoutby 1000 inOpenAIApi; preserve SDK default when unset (10m).packages/openai-adapters/src/apis/OpenAI.test.tsto verify conversion and default behavior.Written for commit 572fe40. Summary will update on new commits.