diff --git a/packages/annotation/src/useSubmitOnCmdEnter.test.ts b/packages/annotation/src/useSubmitOnCmdEnter.test.ts index a409e1c..3ef7f79 100644 --- a/packages/annotation/src/useSubmitOnCmdEnter.test.ts +++ b/packages/annotation/src/useSubmitOnCmdEnter.test.ts @@ -50,10 +50,11 @@ function buildKeyEvent(init: { ctrlKey?: boolean; preventDefault?: () => void; }): KeyboardEvent { + const { key, metaKey = false, ctrlKey = false, preventDefault = () => {} } = init; return { - key: init.key, - metaKey: init.metaKey ?? false, - ctrlKey: init.ctrlKey ?? false, - preventDefault: init.preventDefault ?? (() => {}), + key, + metaKey, + ctrlKey, + preventDefault, } as unknown as KeyboardEvent; } diff --git a/packages/cli/src/testHelpers/annotationFakes.ts b/packages/cli/src/testHelpers/annotationFakes.ts index a865293..6465812 100644 --- a/packages/cli/src/testHelpers/annotationFakes.ts +++ b/packages/cli/src/testHelpers/annotationFakes.ts @@ -33,8 +33,8 @@ export function createAnnotationDependencies( result?: Promise; } = {}, ): TrackedAnnotationDependencies { + const { submission = annotationSubmission.build(), result = Promise.resolve(submission) } = options; const payloads: AnnotationPayload[] = []; - const submission = options.submission ?? annotationSubmission.build(); const sigintRegistration = createDeferred(); let closeCount = 0; let observedPort: number | undefined; @@ -71,7 +71,7 @@ export function createAnnotationDependencies( return { port: 4312, url: 'http://localhost:4312', - result: options.result ?? Promise.resolve(submission), + result, close: () => { closeCount += 1; return Promise.resolve(); diff --git a/packages/cli/src/updater/UpdaterImpl.ts b/packages/cli/src/updater/UpdaterImpl.ts index ac8d983..bc9ccf5 100644 --- a/packages/cli/src/updater/UpdaterImpl.ts +++ b/packages/cli/src/updater/UpdaterImpl.ts @@ -58,14 +58,13 @@ export class UpdaterImpl { constructor(private readonly deps: UpdaterImplDeps) {} async checkForUpdate(options: CheckForUpdateOptions = {}): Promise { - const { buildInfo, env, clock, logger } = this.deps; + const { buildInfo, env, clock, logger, ttl = Temporal.Duration.from({ hours: DEFAULT_TTL_HOURS }) } = this.deps; const { forceRefresh = false } = options; if (buildInfo.version === DEV_BUILD_VERSION) return null; if (env.CONTEXTBRIDGE_UPDATE_CHECK_DISABLED) return null; const now = clock(); - const ttl = this.deps.ttl ?? Temporal.Duration.from({ hours: DEFAULT_TTL_HOURS }); if (!forceRefresh) { const cached = this.readCache(buildInfo.channel, now, ttl);