Add tvOS platform support#76
Closed
om-mani-padme-hum wants to merge 3 commits into
Closed
Conversation
All dependencies (MathJaxSwift, SwiftDraw, swift-html-entities) already declare tvOS support. Since tvOS uses UIKit, the existing iOS/visionOS code paths apply directly. Changes: - Add .tvOS(.v15) to Package.swift platform targets - Include os(tvOS) in all #if os(iOS) || os(visionOS) conditionals - Add tvOS 18.0 to @available checks for TextRenderer/TextAttribute APIs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
Closing in favor of a corrected PR. This branch was based on main (v2.0.0) which uses SwiftDraw instead of SVGView. The replacement PR will be based on the v1.3.2 tag for broader compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tvOS(.v15)to Package.swift platform targetsos(tvOS)in all#if os(iOS) || os(visionOS)conditional compilation checks across 9 source filestvOS 18.0to@availableannotations for TextRenderer/TextAttribute APIs (EquationMarker, LineSpacingNormalizer)Rationale
All three dependencies already support tvOS:
.tvOS(.v13).tvOS(.v13)Since tvOS uses UIKit, the existing iOS/visionOS code paths (UIImage, UIFont, UIColor, UITraitCollection, UIContentSizeCategory, font descriptor traits) all apply directly with no behavioral changes needed.
This follows the same pattern as #41 which added visionOS support.
Test plan
🤖 Generated with Claude Code