fix: Remove hardcoded S3 bucket name in GitHub Actions workflow

- Replace hardcoded S3 bucket name with environment-specific variables
- Add S3_BUCKET_DEV and S3_BUCKET_PROD variables for multi-environment deployment
- Update create_role scripts to register environment-specific S3 bucket variables
- Use GitHub Variables instead of hardcoded values for better flexibility
- Support different S3 buckets for development and production environments

Author: Hirose-Sebastian-Taikai

.github/workflows/deploy.yml

@@ -53,19 +53,22 @@ jobs:
         if [ "${{ github.ref }}" = "refs/heads/main" ]; then
           STACK_NAME="lambda-framework-prod"
           ENVIRONMENT="production"
+          S3_BUCKET="${{ vars.S3_BUCKET_PROD }}"
         else
           STACK_NAME="lambda-framework-dev"
           ENVIRONMENT="development"
+          S3_BUCKET="${{ vars.S3_BUCKET_DEV }}"
         fi
         
         echo "Deploying to environment: $ENVIRONMENT"
         echo "Stack name: $STACK_NAME"
         echo "AWS Region: $AWS_REGION"
+        echo "S3 Bucket: $S3_BUCKET"
         
         sam build
         sam deploy --no-confirm-changeset --no-fail-on-empty-changeset \
           --stack-name $STACK_NAME \
-          --s3-bucket cn-seba-aws-sam-cli-managed-default-samclisourcebucket \
+          --s3-bucket $S3_BUCKET \
           --parameter-overrides ProjectName=${{ env.PROJECT_NAME }} Environment=$ENVIRONMENT
       env:
         AWS_REGION: ${{ env.AWS_REGION }}

create_role.ps1

@@ -1251,6 +1251,23 @@ if ($GITHUB_CLI_AVAILABLE) {
             } else {
                 Write-Warning "PROJECT_NAME の登録に失敗しました: $result"
             }
+            
+            # 環境別S3バケットの登録
+            Write-Info "S3_BUCKET_DEVをRepository Variablesに登録中: $S3_BUCKET"
+            $result = gh variable set S3_BUCKET_DEV --body $S3_BUCKET 2>&1
+            if ($LASTEXITCODE -eq 0) {
+                Write-Success "S3_BUCKET_DEV がRepository Variablesに登録されました"
+            } else {
+                Write-Warning "S3_BUCKET_DEV の登録に失敗しました: $result"
+            }
+            
+            Write-Info "S3_BUCKET_PRODをRepository Variablesに登録中: $S3_BUCKET"
+            $result = gh variable set S3_BUCKET_PROD --body $S3_BUCKET 2>&1
+            if ($LASTEXITCODE -eq 0) {
+                Write-Success "S3_BUCKET_PROD がRepository Variablesに登録されました"
+            } else {
+                Write-Warning "S3_BUCKET_PROD の登録に失敗しました: $result"
+            }
         } else {
             Write-Info "GitHub Secretsの自動登録をスキップしました"
         }
@@ -1278,6 +1295,8 @@ if ($GITHUB_CLI_AVAILABLE) {
     Write-Host "登録されたRepository Variables:" -ForegroundColor Yellow
     Write-Host "- AWS_REGION"
     Write-Host "- PROJECT_NAME"
+    Write-Host "- S3_BUCKET_DEV"
+    Write-Host "- S3_BUCKET_PROD"
 } else {
     Write-Host "手動でGitHubに以下を設定してください:" -ForegroundColor Yellow
     Write-Host ""
@@ -1292,4 +1311,8 @@ if ($GITHUB_CLI_AVAILABLE) {
     Write-Host "Value: $AWS_REGION"
     Write-Host "Name: PROJECT_NAME"
     Write-Host "Value: $PROJECT_NAME"
+    Write-Host "Name: S3_BUCKET_DEV"
+    Write-Host "Value: $S3_BUCKET"
+    Write-Host "Name: S3_BUCKET_PROD"
+    Write-Host "Value: $S3_BUCKET"
 } 

create_role.sh

@@ -1192,6 +1192,19 @@ if [ "$GITHUB_CLI_AVAILABLE" = true ]; then
     else
         print_warning "PROJECT_NAMEの登録に失敗しました"
     fi
+    
+    # 環境別S3バケットの登録
+    if gh variable set S3_BUCKET_DEV --body "$S3_BUCKET" &> /dev/null; then
+        print_success "S3_BUCKET_DEVがRepository Variablesに登録されました"
+    else
+        print_warning "S3_BUCKET_DEVの登録に失敗しました"
+    fi
+    
+    if gh variable set S3_BUCKET_PROD --body "$S3_BUCKET" &> /dev/null; then
+        print_success "S3_BUCKET_PRODがRepository Variablesに登録されました"
+    else
+        print_warning "S3_BUCKET_PRODの登録に失敗しました"
+    fi
     else
         print_info "GitHub Secretsの自動登録をスキップしました"
     fi
@@ -1218,6 +1231,8 @@ if [ "$GITHUB_CLI_AVAILABLE" = true ]; then
     echo "登録されたRepository Variables:"
     echo "- AWS_REGION"
     echo "- PROJECT_NAME"
+    echo "- S3_BUCKET_DEV"
+    echo "- S3_BUCKET_PROD"
 else
     echo "手動でGitHubに以下を設定してください:"
     echo ""
@@ -1232,4 +1247,8 @@ else
     echo "Value: $AWS_REGION"
     echo "Name: PROJECT_NAME"
     echo "Value: $PROJECT_NAME"
+    echo "Name: S3_BUCKET_DEV"
+    echo "Value: $S3_BUCKET"
+    echo "Name: S3_BUCKET_PROD"
+    echo "Value: $S3_BUCKET"
 fi