Bump PHPStan to level 3 and fix type/annotation issues

Raise the PHPStan analysis level from 2 to 3 and resolve the resulting
issues, all safe PHPDoc/annotation corrections with no behavior change:

- Correct return-type PHPDoc to match actual behavior: Assets::
  generate_storage_signature (bool), Assets::build_item (array|null),
  Media::get_transformation (int|string|false), Media::cloudinary_url
  (string|null), Media::filter_downsize (array|false), Media::
  get_context_options (string), Settings::save (string[]), Api::sign
  (string), Api::call (array|string|WP_Error), Page::form/notice and
  Sync::action (array|null), On_Off::sanitize_value (string).
- Widen base Text::sanitize_value PHPDoc to mixed so the array/bool
  overrides (Checkbox, Cron, Crops, React, Tags_Input, On_Off) are
  covariant-compatible.
- Fix settings/setting type confusion: correct Component\Settings
  interface param to Cloudinary\Settings, widen Settings_Component::
  $settings and Delivery_Feature::$settings to Settings|Setting, align
  Gallery/Extensions/Global_Transformations settings property types.
- Fix Setting::$parent (string slug, not self) and get_option_parent
  return (Setting|null).
- Fix Sync::$managers to include Sync_Queue.
- Fix Line_Stat $connect type (Cloudinary\Connect) and narrow at call
  site; allow numeric used_percent/limit.
- Cast ini_get in Cron::$daemon_watcher_interval; default Api::
  $pending_url to null; widen Url_Object::get_id to int|string|null.
- Correct get_terms return-type PHPDoc and annotate video metadata to
  resolve offset access on WP stub arrays.

Author: PatelUtkarsh

php/class-assets.php

@@ -713,7 +713,7 @@ public function generate_file_signature( $asset_id ) {
 	 *
 	 * @param int $asset_id The attachment/asset ID.
 	 *
-	 * @return string
+	 * @return bool
 	 */
 	public function generate_storage_signature( $asset_id ) {
 		return $this->get_asset_storage_folder( $asset_id ) === $this->media->get_public_id( $asset_id );
@@ -1199,7 +1199,7 @@ public function get_asset( $post_id, $type = 'object' ) {
 	 *
 	 * @param array $item The raw data for an asset.
 	 *
-	 * @return array
+	 * @return array|null
 	 */
 	public function build_item( $item ) {
 		if ( empty( $item ) ) {

php/class-cron.php

@@ -81,7 +81,7 @@ public function __construct() {
 
 		// Ensure it's safe.
 		if ( self::$daemon_watcher_interval > ini_get( 'max_execution_time' ) ) {
-			self::$daemon_watcher_interval = ini_get( 'max_execution_time' );
+			self::$daemon_watcher_interval = (int) ini_get( 'max_execution_time' );
 		}
 
 		$this->init_time = time();

php/class-delivery-feature.php

@@ -8,7 +8,6 @@
 namespace Cloudinary;
 
 use Cloudinary\Component\Assets;
-use Cloudinary\Settings\Setting;
 
 /**
  * Class Delivery_Feature
@@ -57,7 +56,7 @@ abstract class Delivery_Feature implements Assets {
 	/**
 	 * Holds the settings.
 	 *
-	 * @var Setting
+	 * @var Settings|\Cloudinary\Settings\Setting
 	 */
 	protected $settings;
 

php/class-extensions.php

@@ -24,7 +24,7 @@ class Extensions extends Settings_Component implements Setup {
 	/**
 	 * Holds the core plugin settings.
 	 *
-	 * @var Settings
+	 * @var Settings|\Cloudinary\Settings\Setting
 	 */
 	protected $settings;
 

php/class-media.php

@@ -941,7 +941,7 @@ public function set_transformation( &$transformations, $type, $value, $index = f
 	 * @param array  $transformations The transformation set to check.
 	 * @param string $type            The type of transformation to check for.
 	 *
-	 * @return bool
+	 * @return int|string|false
 	 */
 	public function get_transformation( $transformations, $type ) {
 		foreach ( $transformations as $index => $transformation ) {
@@ -1372,7 +1372,7 @@ protected function get_cache_key( $args ) {
 	 * @param string|null  $cloudinary_id             Optional forced cloudinary ID.
 	 * @param bool         $overwrite_transformations Flag url is a breakpoint URL to stop re-applying default transformations.
 	 *
-	 * @return string The converted URL.
+	 * @return string|null The converted URL.
 	 */
 	public function cloudinary_url( $attachment_id, $size = array(), $transformations = array(), $cloudinary_id = null, $overwrite_transformations = false ) {
 		static $cache = array();
@@ -1777,11 +1777,11 @@ public function cloudinary_id( $attachment_id ) {
 	/**
 	 * Filter the requested image and return image source.
 	 *
-	 * @param null         $image         The null image value for short circuit check.
+	 * @param array|false  $image         The image value for short circuit check.
 	 * @param int          $attachment_id The ID of the attachment.
 	 * @param string|array $size          The requested size of the image.
 	 *
-	 * @return array The image array of size and url.
+	 * @return array|false The image array of size and url.
 	 * @uses filter:image_downsize
 	 */
 	public function filter_downsize( $image, $attachment_id, $size ) {
@@ -2781,7 +2781,7 @@ public function get_breakpoint_options( $attachment_id ) {
 	 *
 	 * @param int $attachment_id The ID of the attachment.
 	 *
-	 * @return array
+	 * @return string
 	 */
 	public function get_context_options( $attachment_id ) {
 		$caption = get_post( $attachment_id )->post_excerpt;

php/class-settings-component.php

@@ -9,6 +9,7 @@
 
 use Cloudinary\Component;
 use Cloudinary\Settings as CoreSetting;
+use Cloudinary\Settings\Setting;
 
 /**
  * Plugin Settings Component class.
@@ -18,7 +19,7 @@ abstract class Settings_Component implements Component\Settings {
 	/**
 	 * Holds the settings object for this Class.
 	 *
-	 * @var CoreSetting
+	 * @var CoreSetting|Setting
 	 */
 	protected $settings;
 

php/class-settings.php

@@ -590,7 +590,7 @@ public function remove_pending( $slug ) {
 	/**
 	 * Save settings.
 	 *
-	 * @return bool[]|\WP_Error[]
+	 * @return string[]
 	 */
 	public function save() {
 		$pending   = array_keys( $this->get_pending() );

php/class-sync.php

@@ -35,7 +35,7 @@ class Sync implements Setup, Assets {
 	/**
 	 * Contains all the different sync components.
 	 *
-	 * @var Delete_Sync[]|Push_Sync[]|Upload_Sync[]|Media[]|Unsync[]|Download_Sync[]
+	 * @var Delete_Sync[]|Push_Sync[]|Upload_Sync[]|Media[]|Unsync[]|Download_Sync[]|Sync_Queue[]
 	 */
 	public $managers;
 

php/component/class-settings.php

@@ -7,7 +7,7 @@
 
 namespace Cloudinary\Component;
 
-use Cloudinary\Settings\Setting;
+use Cloudinary\Settings as CoreSettings;
 
 /**
  * Defines an object that requires settings.
@@ -17,7 +17,7 @@ interface Settings {
 	/**
 	 * Init Settings Object.
 	 *
-	 * @param Setting $setting The core setting.
+	 * @param CoreSettings $setting The core setting.
 	 */
 	public function init_settings( $setting );
 }

php/connect/class-api.php

@@ -156,7 +156,7 @@ class Api {
 	 *
 	 * @var string|null
 	 */
-	private $pending_url = array();
+	private $pending_url = null;
 
 	/**
 	 * API constructor.
@@ -801,7 +801,7 @@ public function __call( $name, $args ) {
 	 *
 	 * @param array $args Array of parameters to sign.
 	 *
-	 * @return array|\WP_Error
+	 * @return string
 	 */
 	public function sign( $args ) {
 
@@ -988,7 +988,7 @@ protected static function get_hostname( $upload_prefix ) {
 	 * @param array  $args   The optional arguments to send.
 	 * @param string $method The call HTTP method.
 	 *
-	 * @return array|\WP_Error
+	 * @return array|string|\WP_Error
 	 */
 	private function call( $url, $args = array(), $method = 'get' ) {
 		$args['method']             = strtoupper( $method );