fix(ui): throttle self-serve SSO domain verification retries - #9275
fix(ui): throttle self-serve SSO domain verification retries#9275NicolasLopes7 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 8603802 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughConfigureSSO adds ownership-verification retry handling with a five-minute throttle, shared retry controls for expired and unverified TXT-record states, timer cleanup, and tests covering retry visibility, invocation, disabled state, and cooldown re-enabling. A patch changeset documents the behavior. Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
| const retryTimerRef = useRef<number | undefined>(undefined); | ||
| const isVerificationRetryThrottledRef = useRef(false); | ||
|
|
There was a problem hiding this comment.
what's the thinking behind the use of useRef to store timeouts? I feel like useState might be more appropriate but I'd like to understand more
Summary
Testing