chore(ui): fix eslint errors in composed and profile modules (#9242)

Author: alexcarpenter

.changeset/fix-ui-lint.md

@@ -0,0 +1,2 @@
+---
+---

packages/ui/src/components/ConfigureSSO/domain/__tests__/organizationEnterpriseConnection.test.ts

@@ -288,7 +288,7 @@ describe('connectionBackingEmail', () => {
   const email = (id: string, status: 'verified' | 'unverified'): EmailAddressResource =>
     ({ id, emailAddress: `${id}@acme.com`, verification: { status } }) as EmailAddressResource;
 
-  const makeUser = (overrides: Partial<UserResource>): UserResource => overrides as UserResource;
+  const makeUser = (overrides: Partial<UserResource>): UserResource => overrides;
 
   it('returns the primary email when one is present', () => {
     const primary = email('primary', 'verified');

packages/ui/src/components/UserProfile/SecurityPage.tsx

@@ -3,7 +3,7 @@ import { ProfileCard } from '@/ui/elements/ProfileCard';
 
 import { localizationKeys } from '../../customizables';
 import { ActiveDevicesSection } from './ActiveDevicesSection';
-import { SecurityPassword, SecurityPasskeys, SecurityMfa, SecurityDelete } from './SecuritySections';
+import { SecurityDelete, SecurityMfa, SecurityPasskeys, SecurityPassword } from './SecuritySections';
 
 export const SecurityPage = withCardStateProvider(() => {
   const card = useCardState();

packages/ui/src/components/UserProfile/SecuritySections.tsx

@@ -4,15 +4,17 @@ import type { ReactNode } from 'react';
 import { getSecondFactors } from '@/ui/utils/mfa';
 
 import { useEnvironment, useUserProfileContext } from '../../contexts';
+import { DeleteSection } from './DeleteSection';
 import { MfaSection } from './MfaSection';
 import { PasskeySection } from './PasskeySection';
 import { PasswordSection } from './PasswordSection';
-import { DeleteSection } from './DeleteSection';
 
 export function SecurityPassword(): ReactNode {
   const { instanceIsPasswordBased } = useEnvironment().userSettings;
 
-  if (!instanceIsPasswordBased) return null;
+  if (!instanceIsPasswordBased) {
+    return null;
+  }
 
   return <PasswordSection />;
 }
@@ -21,23 +23,29 @@ export function SecurityPasskeys(): ReactNode {
   const { attributes } = useEnvironment().userSettings;
   const { shouldAllowIdentificationCreation } = useUserProfileContext();
 
-  if (!attributes.passkey?.enabled || !shouldAllowIdentificationCreation) return null;
+  if (!attributes.passkey?.enabled || !shouldAllowIdentificationCreation) {
+    return null;
+  }
 
   return <PasskeySection />;
 }
 
 export function SecurityMfa(): ReactNode {
   const { attributes } = useEnvironment().userSettings;
 
-  if (getSecondFactors(attributes).length === 0) return null;
+  if (getSecondFactors(attributes).length === 0) {
+    return null;
+  }
 
   return <MfaSection />;
 }
 
 export function SecurityDelete(): ReactNode {
   const { user } = useUser();
 
-  if (!user?.deleteSelfEnabled) return null;
+  if (!user?.deleteSelfEnabled) {
+    return null;
+  }
 
   return <DeleteSection />;
 }

packages/ui/src/components/UserProfile/__tests__/ConnectedAccountsSection.test.tsx

@@ -168,7 +168,7 @@ describe('ConnectedAccountsSection ', () => {
           open,
         },
       });
-      const reload = vi.spyOn(fixtures.clerk.user!, 'reload').mockResolvedValue(fixtures.clerk.user!);
+      const reload = vi.spyOn(fixtures.clerk.user, 'reload').mockResolvedValue(fixtures.clerk.user);
       fixtures.clerk.user?.createExternalAccount.mockResolvedValue({
         verification: { externalVerificationRedirectURL: new URL('https://provider.example/auth') },
       } as ExternalAccountResource);
@@ -291,7 +291,7 @@ describe('ConnectedAccountsSection ', () => {
           open,
         },
       });
-      const reload = vi.spyOn(fixtures.clerk.user!, 'reload').mockResolvedValue(fixtures.clerk.user!);
+      const reload = vi.spyOn(fixtures.clerk.user, 'reload').mockResolvedValue(fixtures.clerk.user);
       fixtures.clerk.user?.createExternalAccount.mockResolvedValue({
         verification: { externalVerificationRedirectURL: new URL('https://provider.example/auth') },
       } as ExternalAccountResource);

packages/ui/src/components/UserProfile/__tests__/SecuritySections.test.tsx

@@ -5,7 +5,7 @@ import { render, screen } from '@/test/utils';
 import { CardStateProvider } from '@/ui/elements/contexts';
 
 import { clearFetchCache } from '../../../hooks';
-import { SecurityPassword, SecurityPasskeys, SecurityMfa, SecurityDelete } from '../SecuritySections';
+import { SecurityDelete, SecurityMfa, SecurityPasskeys, SecurityPassword } from '../SecuritySections';
 
 const { createFixtures } = bindCreateFixtures('UserProfile');
 

packages/ui/src/composed/APIKeysSection.tsx

@@ -1,6 +1,6 @@
 'use client';
 
-import { Suspense, type ComponentType, type ReactNode } from 'react';
+import { type ComponentType, type ReactNode, Suspense } from 'react';
 
 import { CardStateProvider } from '../elements/contexts';
 

packages/ui/src/composed/BillingSection.tsx

@@ -1,6 +1,6 @@
 'use client';
 
-import { Suspense, type ComponentType, type ReactNode } from 'react';
+import { type ComponentType, type ReactNode, Suspense } from 'react';
 
 import { RouteContext } from '../router/RouteContext';
 import { useBillingRouter } from './useBillingRouter';

packages/ui/src/composed/__tests__/OrganizationProfile.test.tsx

@@ -1,8 +1,7 @@
-import type { ClerkPaginatedResponse, OrganizationMembershipResource } from '@clerk/shared/types';
-import { describe, expect, it } from 'vitest';
+import { describe, it } from 'vitest';
 
 import { bindCreateFixtures } from '@/test/create-fixtures';
-import { render, screen, waitFor } from '@/test/utils';
+import { render, screen } from '@/test/utils';
 
 import { OrganizationGeneralPage } from '../../components/OrganizationProfile/OrganizationGeneralPage';
 

packages/ui/src/composed/__tests__/stub-limitations.test.ts

@@ -1,4 +1,4 @@
-import { renderHook, act } from '@testing-library/react';
+import { act, renderHook } from '@testing-library/react';
 import { afterEach, describe, expect, it, vi } from 'vitest';
 
 import { createComposedRouter, stubRouter } from '../stubRouter';