Skip to content

Commit a6546b1

Browse files
committed
Default prebuilt Expo views to dismissible
1 parent 9889bc0 commit a6546b1

5 files changed

Lines changed: 8 additions & 8 deletions

File tree

packages/expo/ios/ClerkAuthNativeView.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import UIKit
44
public class ClerkAuthNativeView: UIView {
55
private lazy var hostingCoordinator = ClerkNativeHostingCoordinator(containerView: self)
66
private var currentMode: String = "signInOrUp"
7-
private var currentDismissible: Bool = false
7+
private var currentDismissible: Bool = true
88
private var hasInitialized: Bool = false
99
private var didCompleteAuthentication: Bool = false
1010
private var dismissalEventSent: Bool = false
@@ -22,7 +22,7 @@ public class ClerkAuthNativeView: UIView {
2222

2323
@objc var isDismissible: NSNumber? {
2424
didSet {
25-
let newDismissible = isDismissible?.boolValue ?? false
25+
let newDismissible = isDismissible?.boolValue ?? true
2626
guard newDismissible != currentDismissible else { return }
2727
currentDismissible = newDismissible
2828
if hasInitialized { updateView() }

packages/expo/ios/ClerkUserProfileNativeView.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import UIKit
33

44
public class ClerkUserProfileNativeView: UIView {
55
private lazy var hostingCoordinator = ClerkNativeHostingCoordinator(containerView: self)
6-
private var currentDismissible: Bool = false
6+
private var currentDismissible: Bool = true
77
private var hasInitialized: Bool = false
88
private var didSignOut = false
99
private var dismissalEventSent = false
@@ -12,7 +12,7 @@ public class ClerkUserProfileNativeView: UIView {
1212

1313
@objc var isDismissible: NSNumber? {
1414
didSet {
15-
let newDismissible = isDismissible?.boolValue ?? false
15+
let newDismissible = isDismissible?.boolValue ?? true
1616
guard newDismissible != currentDismissible else { return }
1717
currentDismissible = newDismissible
1818
if hasInitialized { updateView() }

packages/expo/src/native/AuthView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import type { AuthViewProps } from './AuthView.types';
3434
*
3535
* @see {@link https://clerk.com/docs/components/authentication/sign-in} Clerk Sign-In Documentation
3636
*/
37-
export function AuthView({ mode = 'signInOrUp', isDismissible = false, onDismiss }: AuthViewProps) {
37+
export function AuthView({ mode = 'signInOrUp', isDismissible = true, onDismiss }: AuthViewProps) {
3838
const handleAuthEvent = useCallback(
3939
(event: { nativeEvent: { type: string } }) => {
4040
if (event.nativeEvent.type === 'dismissed') {

packages/expo/src/native/AuthView.types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export interface AuthViewProps {
3434
* When `false`, the user must complete authentication to close the view.
3535
* Use this for flows where authentication is required to proceed.
3636
*
37-
* @default false
37+
* @default true
3838
*/
3939
isDismissible?: boolean;
4040

packages/expo/src/native/UserProfileView.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export interface UserProfileViewProps {
1515
* This controls the native view's built-in dismiss button. It does not present
1616
* a modal; render `UserProfileView` inside your own `Modal`, sheet, or route.
1717
*
18-
* @default false
18+
* @default true
1919
*/
2020
isDismissible?: boolean;
2121

@@ -60,7 +60,7 @@ export interface UserProfileViewProps {
6060
*
6161
* @see {@link https://clerk.com/docs/components/user/user-profile} Clerk UserProfile Documentation
6262
*/
63-
export function UserProfileView({ isDismissible = false, style, onDismiss }: UserProfileViewProps) {
63+
export function UserProfileView({ isDismissible = true, style, onDismiss }: UserProfileViewProps) {
6464
const handleProfileEvent = useCallback(
6565
(event: { nativeEvent: { type: string } }) => {
6666
if (event.nativeEvent.type === 'dismissed') {

0 commit comments

Comments
 (0)