Skip to content

Keep external drop effect as copy #20184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HardyPotato wants to merge 1 commit into from
+12 −4
Closed

Keep external drop effect as copy #20184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changelog/20260519225000_i_20161.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
type: Fix
scope:
- ckeditor5-clipboard
closes:
- https://github.com/ckeditor/ckeditor5/issues/20161
---

External content dragged into the editor now keeps the copy drop effect instead of being treated as a move operation.
6 changes: 2 additions & 4 deletions packages/ckeditor5-clipboard/src/dragdrop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,10 +376,8 @@ export class DragDrop extends Plugin {
// is not possible until 'dragend' event case will be fixed.
if ( !this._draggedRange ) {
data.dataTransfer.dropEffect = 'copy';
}

// In Firefox it is already set and effect allowed remains the same as originally set.
if ( !env.isGecko ) {
} else if ( !env.isGecko ) {
// In Firefox it is already set and effect allowed remains the same as originally set.
if ( data.dataTransfer.effectAllowed == 'copy' ) {
data.dataTransfer.dropEffect = 'copy';
} else if ( [ 'all', 'copyMove' ].includes( data.dataTransfer.effectAllowed ) ) {
Expand Down
1 change: 1 addition & 0 deletions packages/ckeditor5-clipboard/tests/dragdrop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ describe( 'Drag and Drop', () => {
// Dragging.

targetPosition = model.createPositionAt( root.getChild( 0 ), 5 );
dataTransferMock.effectAllowed = 'copyMove';
fireDragging( dataTransferMock, targetPosition );
clock.tick( 100 );

Expand Down