Skip to content

Split off batched reconciler into its own constructor #161

Description

@joamaki

The current reconciler.New takes both reconciler.Operations and reconciler.BatchOperations. The BatchOperations can be nil in which cases objects are reconciled one at a time.

This API seems to lead to many users assuming that both Operations and BatchOperations need to be implemented. Make the API easier to use correctly by removing the BatchOperations parameter from reconciler.New and introducing a reconciler.NewBatchReconciler constructor. Extend BatchOperations with Prune method and refactor the reconciler to work without single object reconciliation (e.g. the retry handling which should be able to retry a batch).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions