Add draft mode support#258
Conversation
🦋 Changeset detectedLatest commit: 6c9b81e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Docs incoming... |
|
is there something blocking this pr? |
|
@Andarist cold this PR be merged? This is a functionality we'd like to use, too. |
|
Any updates on this? Would like to use this functionality |
|
I know this probably isn't getting merged anytime soon, but I just wanted to mention that, taking a cue from https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs, we probably want the PR to always be set back to a draft when it's updated. So if the versions change it goes back to draft, and if the workflow has Without this, the workflow will get triggered on the first draft -> publish, but not whenever the PR is updated by this action. |
tom-sherman
force-pushed
the
add-draft-mode-support
branch
from
32d69a5 to
4d56b1d
Compare
tom-sherman
force-pushed
the
add-draft-mode-support
branch
from
4d56b1d to
4a745fc
Compare
|
/release-pr |
|
The changesets/action@6016cc9a31082e9751df01b026d92cf17cad56d0 release triggered by this comment has succeeded. |
|
I'd appreciate it if somebody could test this out in their project using the above build. This would certainly allow me to ship this faster. |
|
hey @Andarist thanks for picking this up! I tested it on my project (internal so can't share, sorry!) and it correctly opened the PR as draft in "create" mode. From my POV this looks good to release. |
|
FYI this doesn't provide a complete solution for #187 because if you mark the PR as ready and changesets updates the PR (because something else got merged to main) the required checks won't run. Not a problem with this change, just a caveat on how it relates to that issue. |
|
@tom-sherman a nice workaround for this might be to use an internal GitHub app and use its token like here. You don't even have to host an actual application anywhere, just put the app's private key into the secrets and ensure the app has the needed permissions and the secret can't be used in unsafe contexts etc |
|
@Andarist just today after this PR I started to see similar issues like #187. Hadn't seen any of those before. Could this PR be related? It was working fine earlier this week. chromaui/chromatic-e2e#344 |
|
@AriPerkkio I don't see any checks executed in this PR from 3 days ago: |
10 participants
Closes #257