|
| 1 | +// |
| 2 | +// Copyright 2026 The Chainloop Authors. |
| 3 | +// |
| 4 | +// Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | +// you may not use this file except in compliance with the License. |
| 6 | +// You may obtain a copy of the License at |
| 7 | +// |
| 8 | +// http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | +// |
| 10 | +// Unless required by applicable law or agreed to in writing, software |
| 11 | +// distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | +// See the License for the specific language governing permissions and |
| 14 | +// limitations under the License. |
| 15 | + |
| 16 | +package attestation_test |
| 17 | + |
| 18 | +import ( |
| 19 | + "encoding/base64" |
| 20 | + "testing" |
| 21 | + |
| 22 | + "github.com/chainloop-dev/chainloop/pkg/attestation" |
| 23 | + "github.com/secure-systems-lab/go-securesystemslib/dsse" |
| 24 | + "github.com/stretchr/testify/assert" |
| 25 | + "github.com/stretchr/testify/require" |
| 26 | +) |
| 27 | + |
| 28 | +// Guards against the double-base64 bug in https://github.com/chainloop-dev/chainloop/issues/1832. |
| 29 | +func TestBundleFromDSSEEnvelopeDecodesSignature(t *testing.T) { |
| 30 | + rawSig := []byte{0x30, 0x44, 0x02, 0x20, 0xAA, 0xBB, 0xCC, 0xDD} |
| 31 | + rawPayload := []byte(`{"_type":"statement"}`) |
| 32 | + |
| 33 | + env := &dsse.Envelope{ |
| 34 | + PayloadType: "application/vnd.in-toto+json", |
| 35 | + Payload: base64.StdEncoding.EncodeToString(rawPayload), |
| 36 | + Signatures: []dsse.Signature{ |
| 37 | + {KeyID: "key-1", Sig: base64.StdEncoding.EncodeToString(rawSig)}, |
| 38 | + }, |
| 39 | + } |
| 40 | + |
| 41 | + bundle, err := attestation.BundleFromDSSEEnvelope(env) |
| 42 | + require.NoError(t, err) |
| 43 | + |
| 44 | + gotEnv := bundle.GetDsseEnvelope() |
| 45 | + assert.Equal(t, rawPayload, gotEnv.GetPayload()) |
| 46 | + require.Len(t, gotEnv.GetSignatures(), 1) |
| 47 | + assert.Equal(t, rawSig, gotEnv.GetSignatures()[0].GetSig()) |
| 48 | + assert.Equal(t, "key-1", gotEnv.GetSignatures()[0].GetKeyid()) |
| 49 | +} |
| 50 | + |
| 51 | +func TestBundleRoundTripWithFixedSignature(t *testing.T) { |
| 52 | + rawSig := []byte{0x30, 0x44, 0x02, 0x20, 0xAA, 0xBB, 0xCC, 0xDD} |
| 53 | + encodedSig := base64.StdEncoding.EncodeToString(rawSig) |
| 54 | + |
| 55 | + env := &dsse.Envelope{ |
| 56 | + PayloadType: "application/vnd.in-toto+json", |
| 57 | + Payload: base64.StdEncoding.EncodeToString([]byte("payload")), |
| 58 | + Signatures: []dsse.Signature{ |
| 59 | + {KeyID: "key-1", Sig: encodedSig}, |
| 60 | + }, |
| 61 | + } |
| 62 | + |
| 63 | + bundle, err := attestation.BundleFromDSSEEnvelope(env) |
| 64 | + require.NoError(t, err) |
| 65 | + |
| 66 | + before := bundle.GetDsseEnvelope().GetSignatures()[0].GetSig() |
| 67 | + attestation.FixSignatureInBundle(bundle) |
| 68 | + assert.Equal(t, before, bundle.GetDsseEnvelope().GetSignatures()[0].GetSig(), |
| 69 | + "FixSignatureInBundle should be a no-op on properly formed bundles") |
| 70 | + |
| 71 | + gotEnv := attestation.DSSEEnvelopeFromBundle(bundle) |
| 72 | + assert.Equal(t, encodedSig, gotEnv.Signatures[0].Sig) |
| 73 | +} |
| 74 | + |
| 75 | +func TestFixSignatureInBundleRepairsLegacyBundles(t *testing.T) { |
| 76 | + rawSig := []byte{0x30, 0x44, 0x02, 0x20, 0xAA, 0xBB, 0xCC, 0xDD} |
| 77 | + encodedSig := base64.StdEncoding.EncodeToString(rawSig) |
| 78 | + |
| 79 | + env := &dsse.Envelope{ |
| 80 | + PayloadType: "application/vnd.in-toto+json", |
| 81 | + Payload: base64.StdEncoding.EncodeToString([]byte("payload")), |
| 82 | + Signatures: []dsse.Signature{ |
| 83 | + {KeyID: "key-1", Sig: encodedSig}, |
| 84 | + }, |
| 85 | + } |
| 86 | + bundle, err := attestation.BundleFromDSSEEnvelope(env) |
| 87 | + require.NoError(t, err) |
| 88 | + |
| 89 | + // Simulate the legacy bug: signature is stored as the ASCII bytes of the base64 string. |
| 90 | + bundle.GetDsseEnvelope().GetSignatures()[0].Sig = []byte(encodedSig) |
| 91 | + |
| 92 | + attestation.FixSignatureInBundle(bundle) |
| 93 | + assert.Equal(t, rawSig, bundle.GetDsseEnvelope().GetSignatures()[0].GetSig()) |
| 94 | +} |
0 commit comments