Skip to content

Commit 3c11e05

Browse files
committed
lint: fix unused parameter warnings in test functions
- Replace s.T().Run with s.Run to avoid unused testing.T parameter - Fix unused parameter warnings in TestLeaveHappyPath test functions - Address revive linter warnings for better code quality Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
1 parent bfb0b27 commit 3c11e05

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

app/controlplane/pkg/biz/membership_integration_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func (s *membershipIntegrationTestSuite) TestDeleteWithOrg() {
107107
s.True(biz.IsNotFound(err))
108108
})
109109

110-
s.T().Run("cannot leave when the only member (sole owner)", func(t *testing.T) {
110+
s.Run("cannot leave when the only member (sole owner)", func() {
111111
err := s.Membership.Leave(ctx, user.ID, mUser.ID.String())
112112
s.Require().Error(err)
113113
s.True(biz.IsErrValidation(err))
@@ -168,7 +168,7 @@ func (s *membershipIntegrationTestSuite) TestLeaveHappyPath() {
168168
s.Len(members, 2)
169169
s.Equal(2, count)
170170

171-
s.T().Run("owner can leave when another owner remains", func(t *testing.T) {
171+
s.Run("owner can leave when another owner remains", func() {
172172
// user1 can leave because user2 will still be an owner
173173
err := s.Membership.Leave(ctx, user1.ID, membership1.ID.String())
174174
s.NoError(err)
@@ -192,7 +192,7 @@ func (s *membershipIntegrationTestSuite) TestLeaveHappyPath() {
192192
s.Empty(user1Memberships) // user1 should have no memberships left
193193
})
194194

195-
s.T().Run("last remaining owner cannot leave", func(t *testing.T) {
195+
s.Run("last remaining owner cannot leave", func() {
196196
// user2 is now the sole owner and cannot leave
197197
err := s.Membership.Leave(ctx, user2.ID, membership2.ID.String())
198198
s.Error(err)

0 commit comments

Comments
 (0)