From 038a35c28b8b34b3c42c102561010ab68e49961c Mon Sep 17 00:00:00 2001 From: "A.S. Lomoff" Date: Fri, 26 Sep 2014 14:04:04 +0200 Subject: [PATCH 1/2] add .python-version to gitignore --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 6b90cc8..04dbce3 100644 --- a/.gitignore +++ b/.gitignore @@ -43,3 +43,5 @@ output/*/index.html docs/_build .bzr +.python-version + From 1552ad5b758599b3a87f3ed5e4fc45162b5778e5 Mon Sep 17 00:00:00 2001 From: "A.S. Lomoff" Date: Fri, 26 Sep 2014 14:16:21 +0200 Subject: [PATCH 2/2] replace len(..) > 0 with simple casting to boolean --- charmhelpers/core/services/helpers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charmhelpers/core/services/helpers.py b/charmhelpers/core/services/helpers.py index 4b90589..8d1af74 100644 --- a/charmhelpers/core/services/helpers.py +++ b/charmhelpers/core/services/helpers.py @@ -45,7 +45,7 @@ def is_ready(self): """ Returns True if all of the `required_keys` are available from any units. """ - ready = len(self.get(self.name, [])) > 0 + ready = !!self.get(self.name, []) if not ready: hookenv.log('Incomplete relation: {}'.format(self.__class__.__name__), hookenv.DEBUG) return ready