From e51522fe9eaea8d5005ee58b4385b16ee642146f Mon Sep 17 00:00:00 2001 From: Jonathan Tatum Date: Thu, 11 Jun 2026 10:53:19 -0700 Subject: [PATCH] Update abbreviation / import validation. More closely match the validation in the go and java implementations. PiperOrigin-RevId: 930622025 --- common/container.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/common/container.cc b/common/container.cc index f69f0cc80..e1db8f86c 100644 --- a/common/container.cc +++ b/common/container.cc @@ -19,6 +19,7 @@ #include "absl/status/status.h" #include "absl/status/statusor.h" +#include "absl/strings/ascii.h" #include "absl/strings/str_cat.h" #include "absl/strings/string_view.h" #include "internal/lexis.h" @@ -92,9 +93,11 @@ absl::Status ExpressionContainer::SetContainer(absl::string_view name) { } absl::Status ExpressionContainer::AddAbbreviation(absl::string_view abrev) { + abrev = absl::StripAsciiWhitespace(abrev); if (!IsValidQualifiedName(abrev)) { return absl::InvalidArgumentError( - absl::StrCat("invalid qualified name: ", abrev)); + absl::StrCat("invalid qualified name: ", abrev, + ", wanted name of the form 'qualified.name'")); } auto pos = abrev.rfind('.');