chore(cli): remove createYargsForComponentGeneration and its unused import

[lisa-assistant]

Problem

In packages/cli/src/commands/generate/yargsHandlerHelpers.js, two TODOs mark code that was meant to be temporary during the CLI refactor:

Line 23:

// TODO: Remove this import. This is only temporarily to be able to split one
// command at a time into a separate async handler
import {
  createCommand,
  createDescription,
  createBuilder,
} from './yargsCommandHelpers.js'

Line 207:

// TODO: Remove this function. This is only temporarily to be able to split one
// command at a time into a separate async handler
export const createYargsForComponentGeneration = ({ ... }) => { ... }

The migration is now complete. No production command uses createYargsForComponentGeneration — every generator (cell, page, component, directive, job, function, etc.) now has its own *Handler.js file. Several of them even have comments like // This could be built using createYargsForComponentGeneration confirming they deliberately did not use it.

The only consumer of createYargsForComponentGeneration is the test file:
packages/cli/src/commands/generate/__tests__/createYargsForComponentGeneration.test.js

Fix

1. Remove the createCommand, createDescription, createBuilder import from yargsHandlerHelpers.js (lines 23–29)
2. Remove the createYargsForComponentGeneration export from yargsHandlerHelpers.js (lines 207–248)
3. Delete the test file __tests__/createYargsForComponentGeneration.test.js

No other files need updating — nothing imports createYargsForComponentGeneration outside of that test.

Files to change

• packages/cli/src/commands/generate/yargsHandlerHelpers.js — remove import (lines 23–29) and function (lines 207–248)
• packages/cli/src/commands/generate/__tests__/createYargsForComponentGeneration.test.js — delete

[lisa-assistant]

Self-fix confidence: 9/10

This is pure dead-code removal. The function being removed has no production callers. The one test file for it is testing the function in isolation and can be deleted wholesale. The only risk is if I missed an import somewhere (e.g. in a non-standard test helper), but a grep across the monorepo confirms there are no other consumers.

[lisa-assistant]

Implementation Plan

Goal: Remove the createYargsForComponentGeneration function and its re-exported helpers from yargsHandlerHelpers.js — the function has no production callers and exists only as a migration stepping stone that was never completed.

---

Files to change

1. packages/cli/src/commands/generate/yargsHandlerHelpers.js

Remove the import block (lines 23–29):

// TODO: Remove this import. This is only temporarily to be able to split one
// command at a time into a separate async handler
import {
  createCommand,
  createDescription,
  createBuilder,
} from './yargsCommandHelpers.js'

Remove the function (lines 207–234):

// TODO: Remove this function. This is only temporarily to be able to split one
// command at a time into a separate async handler
export const createYargsForComponentGeneration = ({ ... }) => { ... }

Why it's safe: createCommand, createDescription, and createBuilder are imported directly by other files (cell/cell.js, page/page.js, component/component.js) from yargsCommandHelpers.js — those files won't be affected. The "could be built using" comments in function/function.js, job/job.js, job/jobHandler.js, and setup/generator/generator.js confirm these callers deliberately chose not to use this function.

2. packages/cli/src/commands/generate/__tests__/createYargsForComponentGeneration.test.js

Delete this file entirely. It tests only createYargsForComponentGeneration, which is being removed.

---

Approach

1. Remove the import block and function body from yargsHandlerHelpers.js
2. Delete __tests__/createYargsForComponentGeneration.test.js
3. Run yarn vitest packages/cli to confirm nothing breaks

---

Edge cases

• No other file in the monorepo imports createYargsForComponentGeneration (the only import is in the test file being deleted).
• The createHandler function used internally by createYargsForComponentGeneration is also exported from yargsHandlerHelpers.js and does have callers — do not remove createHandler.
• createCommand/createDescription/createBuilder remain available from their source module yargsCommandHelpers.js; nothing breaks downstream.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.