From 8d23db97cf71b230d184fbe224fa337433e8a19f Mon Sep 17 00:00:00 2001 From: Luke Melia Date: Thu, 9 Jul 2026 22:51:37 -0400 Subject: [PATCH 1/3] Sweep remaining command-naming residue in tests, selectors, and locals MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Test surfaces move to tool naming: tests/integration/tools/ (dir + the command-named files inside), acceptance/tools-test.gts, the ai-assistant-panel tools-test, the matrix tools spec, and the module titles in each. Component CSS classes (tool-description, tool-result-card-*, the tool-field embedded styles) and the remaining host identifier residue (toolToRun, instantiateToolInput, messageTool, skillTool, the drain-queue members, isAutoExecutableTool, ...) follow. Restores the catalog test-card getService('tool-service') fix that was lost from the CS-12040 lineage during a rebase — runtime was unaffected (the command-service alias initializer resolves the old key) but the catalog typecheck was red. The command-runner route's data-command-result output attribute is deliberately untouched: the route is an external URL contract and the attribute is part of its consumed DOM surface. Part of the command -> tool rename close-out (CS-12042 / CS-11788). Co-Authored-By: Claude Fable 5 --- .../ai-bot/tests/prompt-construction-test.ts | 2 +- packages/base/commands/search-card-result.gts | 10 +- packages/base/tool-field.gts | 28 +-- .../code-block/tool-call-header.gts | 10 +- .../components/matrix/room-message-tool.gts | 62 +++--- .../app/components/matrix/room-message.gts | 2 +- packages/host/app/components/matrix/room.gts | 10 +- packages/host/app/lib/file-def-manager.ts | 14 +- .../app/lib/matrix-classes/message-builder.ts | 30 +-- packages/host/app/lib/tool-auto-execute.ts | 2 +- packages/host/app/routes/command-runner.ts | 14 +- packages/host/app/services/matrix-service.ts | 4 +- packages/host/app/services/tool-service.ts | 134 +++++++------ .../app/tools/create-ai-assistant-room.ts | 6 +- .../{commands-test.gts => tools-test.gts} | 10 +- packages/host/tests/helpers/index.gts | 4 +- .../get-catalog-realm-identifiers-test.gts | 79 -------- .../invalidate-realm-identifiers-test.gts | 179 ------------------ .../persist-module-inspector-view-test.gts | 91 --------- .../{commands-test.gts => tools-test.gts} | 10 +- ...dd-field-to-card-definition-tool-test.gts} | 2 +- .../apply-markdown-edit-test.gts | 2 +- .../apply-search-replace-block-test.gts | 2 +- .../{commands => tools}/authed-fetch-test.gts | 2 +- .../bot-registration-test.gts | 2 +- .../can-read-realm-test.gts | 2 +- .../cancel-indexing-job-test.gts | 2 +- .../check-correctness-test.gts | 2 +- .../check-domain-availability-test.gts | 2 +- .../copy-and-edit-test.gts | 2 +- .../{commands => tools}/copy-card-test.gts | 2 +- .../copy-file-to-realm-test.gts | 2 +- .../{commands => tools}/copy-source-test.gts | 2 +- .../create-listing-pr-request-test.gts | 2 +- .../{commands => tools}/create-spec-test.gts | 0 .../evaluate-module-test.gts | 2 +- .../execute-atomic-operations-test.gts | 2 +- .../fetch-card-json-test.gts | 2 +- .../full-reindex-realm-test.gts | 2 +- .../generate-example-cards-one-shot-test.gts | 0 .../get-available-realm-identifiers-test.gts | 2 +- .../get-catalog-realm-identifiers-test.gts | 74 ++++++++ .../get-default-writable-realm-test.gts | 2 +- .../get-published-realms-test.gts | 2 +- .../get-realm-of-resource-identifier-test.gts | 2 +- .../get-user-system-card-test.gts | 2 +- .../instantiate-card-test.gts | 2 +- .../invalidate-realm-identifiers-test.gts | 172 +++++++++++++++++ .../invite-user-to-room-test.gts | 2 +- .../load-default-skills-test.gts | 2 +- .../migrate-skill-test.gts | 2 +- .../open-create-listing-modal-test.gts | 2 +- .../open-workspace-test.gts | 2 +- .../{commands => tools}/patch-code-test.gts | 2 +- .../{commands => tools}/patch-fields-test.gts | 0 .../patch-instance-test.gts | 2 +- .../persist-module-inspector-view-test.gts | 88 +++++++++ .../preview-format-test.gts | 0 .../publish-realm-test.gts | 2 +- .../read-card-for-ai-assistant-test.gts | 2 +- .../read-file-for-ai-assistant-test.gts | 2 +- .../{commands => tools}/read-source-test.gts | 2 +- .../read-text-file-test.gts | 2 +- .../reindex-realm-test.gts | 2 +- .../sanitize-module-list-test.gts | 2 +- .../schema-generation-test.gts | 0 .../search-and-choose-test.gts | 2 +- .../search-google-images-test.gts | 2 +- .../search-tool-test.gts} | 2 +- .../send-ai-assistant-message-test.gts | 2 +- .../send-bot-trigger-event-test.gts | 2 +- .../send-request-via-proxy-test.gts | 2 +- .../set-user-system-card-test.gts | 2 +- .../{commands => tools}/show-card-test.gts | 0 .../{commands => tools}/store-add-test.gts | 2 +- .../summarize-session-test.gts | 2 +- .../switch-submode-test.gts | 2 +- .../sync-openrouter-models-test.gts | 2 +- .../tools-calling-test.gts} | 2 +- .../transform-cards-test.gts | 2 +- .../unpublish-realm-test.gts | 2 +- .../update-room-skills-test.gts | 0 .../use-ai-assistant-test.gts | 2 +- .../validate-realm-test.gts | 2 +- .../write-binary-file-test.gts | 2 +- .../write-text-file-test.gts | 2 +- .../unit/lib/command-auto-execute-test.ts | 40 ++-- .../matrix/tests/correctness-checks.spec.ts | 6 +- .../tests/{commands.spec.ts => tools.spec.ts} | 4 +- 89 files changed, 582 insertions(+), 615 deletions(-) rename packages/host/tests/acceptance/{commands-test.gts => tools-test.gts} (99%) delete mode 100644 packages/host/tests/integration/commands/get-catalog-realm-identifiers-test.gts delete mode 100644 packages/host/tests/integration/commands/invalidate-realm-identifiers-test.gts delete mode 100644 packages/host/tests/integration/commands/persist-module-inspector-view-test.gts rename packages/host/tests/integration/components/ai-assistant-panel/{commands-test.gts => tools-test.gts} (99%) rename packages/host/tests/integration/{commands/add-field-to-card-definition-command-test.gts => tools/add-field-to-card-definition-tool-test.gts} (98%) rename packages/host/tests/integration/{commands => tools}/apply-markdown-edit-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/apply-search-replace-block-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/authed-fetch-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/bot-registration-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/can-read-realm-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/cancel-indexing-job-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/check-correctness-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/check-domain-availability-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/copy-and-edit-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/copy-card-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/copy-file-to-realm-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/copy-source-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/create-listing-pr-request-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/create-spec-test.gts (100%) rename packages/host/tests/integration/{commands => tools}/evaluate-module-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/execute-atomic-operations-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/fetch-card-json-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/full-reindex-realm-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/generate-example-cards-one-shot-test.gts (100%) rename packages/host/tests/integration/{commands => tools}/get-available-realm-identifiers-test.gts (97%) create mode 100644 packages/host/tests/integration/tools/get-catalog-realm-identifiers-test.gts rename packages/host/tests/integration/{commands => tools}/get-default-writable-realm-test.gts (96%) rename packages/host/tests/integration/{commands => tools}/get-published-realms-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/get-realm-of-resource-identifier-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/get-user-system-card-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/instantiate-card-test.gts (98%) create mode 100644 packages/host/tests/integration/tools/invalidate-realm-identifiers-test.gts rename packages/host/tests/integration/{commands => tools}/invite-user-to-room-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/load-default-skills-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/migrate-skill-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/open-create-listing-modal-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/open-workspace-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/patch-code-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/patch-fields-test.gts (100%) rename packages/host/tests/integration/{commands => tools}/patch-instance-test.gts (99%) create mode 100644 packages/host/tests/integration/tools/persist-module-inspector-view-test.gts rename packages/host/tests/integration/{commands => tools}/preview-format-test.gts (100%) rename packages/host/tests/integration/{commands => tools}/publish-realm-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/read-card-for-ai-assistant-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/read-file-for-ai-assistant-test.gts (96%) rename packages/host/tests/integration/{commands => tools}/read-source-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/read-text-file-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/reindex-realm-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/sanitize-module-list-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/schema-generation-test.gts (100%) rename packages/host/tests/integration/{commands => tools}/search-and-choose-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/search-google-images-test.gts (99%) rename packages/host/tests/integration/{commands/search-command-test.gts => tools/search-tool-test.gts} (98%) rename packages/host/tests/integration/{commands => tools}/send-ai-assistant-message-test.gts (96%) rename packages/host/tests/integration/{commands => tools}/send-bot-trigger-event-test.gts (96%) rename packages/host/tests/integration/{commands => tools}/send-request-via-proxy-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/set-user-system-card-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/show-card-test.gts (100%) rename packages/host/tests/integration/{commands => tools}/store-add-test.gts (96%) rename packages/host/tests/integration/{commands => tools}/summarize-session-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/switch-submode-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/sync-openrouter-models-test.gts (98%) rename packages/host/tests/integration/{commands/commands-calling-test.gts => tools/tools-calling-test.gts} (98%) rename packages/host/tests/integration/{commands => tools}/transform-cards-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/unpublish-realm-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/update-room-skills-test.gts (100%) rename packages/host/tests/integration/{commands => tools}/use-ai-assistant-test.gts (99%) rename packages/host/tests/integration/{commands => tools}/validate-realm-test.gts (97%) rename packages/host/tests/integration/{commands => tools}/write-binary-file-test.gts (98%) rename packages/host/tests/integration/{commands => tools}/write-text-file-test.gts (99%) rename packages/matrix/tests/{commands.spec.ts => tools.spec.ts} (99%) diff --git a/packages/ai-bot/tests/prompt-construction-test.ts b/packages/ai-bot/tests/prompt-construction-test.ts index a8a457be9f..9590786c9f 100644 --- a/packages/ai-bot/tests/prompt-construction-test.ts +++ b/packages/ai-bot/tests/prompt-construction-test.ts @@ -7343,7 +7343,7 @@ module('markdown skills', () => { }); }); -module('markdown skill commands', (hooks) => { +module('markdown skill tools', (hooks) => { let fakeMatrixClient: FakeMatrixClient; let mockResponses: Map; let originalFetch: any; diff --git a/packages/base/commands/search-card-result.gts b/packages/base/commands/search-card-result.gts index c62267eb11..013f7ec7ce 100644 --- a/packages/base/commands/search-card-result.gts +++ b/packages/base/commands/search-card-result.gts @@ -181,7 +181,7 @@ class SearchCardsResultEmbeddedView extends Component< }