sonar fix

Author: deepikaSingh2711

sdm/src/main/java/com/sap/cds/sdm/service/handler/SDMCustomServiceHandler.java

@@ -671,19 +671,10 @@ private CopyAttachmentsResult copyAttachmentsToSDM(
               objectId,
               invalidProperties.size(),
               invalidProperties);
-          try {
-            sdmService.deleteDocument(
-                "delete",
-                copiedObjectId,
-                request.getContext().getUserInfo().getName(),
-                request.getIsSystemUser());
-            logger.info("Deleted invalid copied attachment: {}", copiedObjectId);
-          } catch (Exception deleteEx) {
-            logger.error(
-                "Failed to delete invalid copied attachment {}: {}",
-                copiedObjectId,
-                deleteEx.getMessage());
-          }
+          deleteInvalidCopiedAttachment(
+              copiedObjectId,
+              request.getContext().getUserInfo().getName(),
+              request.getIsSystemUser());
           // Add to failed attachments list instead of throwing exception
           Map<String, String> failure = new HashMap<>();
           failure.put(OBJECT_ID_KEY, objectId);
@@ -1650,6 +1641,19 @@ private void handleCopyFailure(
     throw new ServiceException(e.getMessage());
   }
 
+  private void deleteInvalidCopiedAttachment(
+      String copiedObjectId, String userName, Boolean isSystemUser) {
+    try {
+      sdmService.deleteDocument("delete", copiedObjectId, userName, isSystemUser);
+      logger.info("Deleted invalid copied attachment: {}", copiedObjectId);
+    } catch (Exception deleteEx) {
+      logger.error(
+          "Failed to delete invalid copied attachment {}: {}",
+          copiedObjectId,
+          deleteEx.getMessage());
+    }
+  }
+
   private String resolveUpIdKey(EventContext context, String parentEntity, String compositionName) {
     logger.debug(
         "Resolving upIdKey for parentEntity: {}, compositionName: {}",