sonar fixes

Author: yashmeet29

sdm/src/main/java/com/sap/cds/sdm/constants/SDMErrorKeys.java

@@ -1,5 +1,7 @@
 package com.sap.cds.sdm.constants;
 
+import com.sap.cds.sdm.utilities.SDMUtils;
+import com.sap.cds.services.ServiceException;
 import java.lang.reflect.Field;
 import java.lang.reflect.Modifier;
 import java.util.Collections;
@@ -20,7 +22,6 @@ private SDMErrorKeys() {
   public static final String VIRUS_REPO_ERROR_MORE_THAN_400MB_KEY =
       "SDM.virusRepoErrorMoreThan400MB";
   public static final String VIRUS_ERROR_KEY = "SDM.virusError";
-  public static final String SDM_DUPLICATE_ATTACHMENT_KEY = "SDM.sdmDuplicateAttachment";
   public static final String REPOSITORY_ERROR_KEY = "SDM.repositoryError";
   public static final String SDM_MISSING_ROLES_EXCEPTION_KEY = "SDM.sdmMissingRolesException";
   public static final String SDM_SERVER_ERROR_KEY = "SDM.sdmServerError";
@@ -105,12 +106,10 @@ private SDMErrorKeys() {
   public static final String INVALID_SECONDARY_PROPERTIES_FOR_MOVE_SUFFIX_KEY =
       "SDM.invalidSecondaryPropertiesForMoveSuffix";
   public static final String SDM_MOVE_OPERATION_FAILED_KEY = "SDM.sdmMoveOperationFailed";
-
-  // public static final String FILENAME_EMPTY_ERROR_MSG = "SDM.File.filenameEmptyError";
-  // public static final String SDM_ROLES_ERROR_MSG = "SDM.Authorization.sdmRolesError";
-  // public static final String USER_NOT_AUTHORISED_ERROR_OPEN_ATTACHMENT_MSG =
-  //     "SDM.Authorization.userNotAuthorizedAttachmentError";
-  // public static final String FAILED_TO_FETCH_FACET_MSG = "SDM.Facet.failedToFetchFacetError";
+  public static final String FAILED_TO_ACCESS_ERROR_KEY_FIELDS_KEY =
+      "SDM.failedToAccessErrorKeyFields";
+  public static final String FAILED_TO_ACCESS_ERROR_MESSAGES_FIELDS_KEY =
+      "SDM.failedToAccessErrorMessagesFields";
 
   public static Map<String, Object> getAllErrorKeys() {
     Map<String, Object> out = new LinkedHashMap<>();
@@ -120,6 +119,8 @@ public static Map<String, Object> getAllErrorKeys() {
         try {
           out.put(f.getName(), f.get(null));
         } catch (IllegalAccessException ignored) {
+          throw new ServiceException(
+              SDMUtils.getErrorMessage("FAILED_TO_ACCESS_ERROR_KEY_FIELDS"), ignored);
         }
       }
     }

sdm/src/main/java/com/sap/cds/sdm/constants/SDMErrorMessages.java

@@ -1,6 +1,7 @@
 package com.sap.cds.sdm.constants;
 
 import com.sap.cds.sdm.utilities.SDMUtils;
+import com.sap.cds.services.ServiceException;
 import java.lang.reflect.Field;
 import java.lang.reflect.Modifier;
 import java.util.Collection;
@@ -26,7 +27,6 @@ private SDMErrorMessages() {
   public static final String VIRUS_REPO_ERROR_MORE_THAN_400MB =
       "You cannot upload files that are larger than 400 MB";
   public static final String VIRUS_ERROR = "%s contains potential malware and cannot be uploaded.";
-  // public static final String SDM_DUPLICATE_ATTACHMENT = "SDM.DuplicateAttachment";
   public static final String REPOSITORY_ERROR = "Failed to get repository info.";
   public static final String SDM_MISSING_ROLES_EXCEPTION =
       "You do not have the required permissions to update attachments. Kindly contact the admin";
@@ -124,6 +124,10 @@ private SDMErrorMessages() {
   public static final String INVALID_SECONDARY_PROPERTIES_FOR_MOVE_SUFFIX =
       ". Attachment rolled back to source.";
   public static final String SDM_MOVE_OPERATION_FAILED = "SDM move operation failed";
+  public static final String FAILED_TO_ACCESS_ERROR_KEY_FIELDS =
+      "Failed to access SDM error key fields";
+  public static final String FAILED_TO_ACCESS_ERROR_MESSAGES_FIELDS =
+      "Failed to access SDM error messages fields";
 
   // Helper Methods to create error/warning messages
   public static String buildErrorMessage(
@@ -255,6 +259,8 @@ public static Map<String, Object> getAllErrorMessages() {
         try {
           out.put(f.getName(), f.get(null));
         } catch (IllegalAccessException ignored) {
+          throw new ServiceException(
+              SDMUtils.getErrorMessage("FAILED_TO_ACCESS_ERROR_MESSAGES_FIELDS"), ignored);
         }
       }
     }

sdm/src/main/java/com/sap/cds/sdm/handler/applicationservice/SDMReadAttachmentsHandler.java

@@ -63,14 +63,17 @@ private void setErrorMessagesInCache(CdsReadEventContext context) {
     String cacheValue = errorMessageCache.get(cacheCheckKey);
 
     if ("true".equals(cacheValue)) {
+      System.out.println("Localized error messages already cached.");
       return; // Skip processing if already cached
     }
 
     Map<String, Object> errorMessages = SDMErrorMessages.getAllErrorMessages();
     Map<String, Object> errorKeys = SDMErrorKeys.getAllErrorKeys();
     String localizedMessage;
     String localizedErrorMessageKey;
-    for (String errorMessage : errorMessages.keySet()) {
+    for (Map.Entry<String, Object> entry : errorMessages.entrySet()) {
+      String errorMessage = entry.getKey();
+      Object errorValue = entry.getValue();
       localizedErrorMessageKey = String.valueOf(errorKeys.get(errorMessage + "_KEY"));
       localizedMessage =
           context
@@ -82,7 +85,7 @@ private void setErrorMessagesInCache(CdsReadEventContext context) {
       errorMessageCache.put(
           errorMessageKey,
           java.util.Objects.equals(localizedMessage, localizedErrorMessageKey)
-              ? String.valueOf(errorMessages.get(errorMessage))
+              ? String.valueOf(errorValue)
               : localizedMessage);
     }