Merge pull request #382 from cap-java/sonarFix

sonar Issue Fix

Author: deepikaSingh2711

CHANGELOG.md

@@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
+## Version 1.6.2
+
+### Fixed
+- Deep copying of custom properties and notes when copying attachments
+- Dynamic primary key extraction from entity schema
+- Facet parsing for parent entity and composition extraction during attachment copy
+- Draft discard operation with attachments
+- Service namespace support in createLink feature
+
 ## Version 1.6.1
 
 ### Fixed

sdm/src/main/java/com/sap/cds/sdm/service/SDMServiceImpl.java

@@ -326,7 +326,7 @@ public List<String> getObject(
     HttpGet getObjectRequest = new HttpGet(sdmUrl);
     try (var response = (CloseableHttpResponse) httpClient.execute(getObjectRequest)) {
       if (response.getStatusLine().getStatusCode() != 200) {
-        return null;
+        return Collections.emptyList();
       }
       String responseString = EntityUtils.toString(response.getEntity());
       JSONObject jsonObject = new JSONObject(responseString);

sdm/src/test/java/unit/com/sap/cds/sdm/service/SDMServiceImplTest.java

@@ -1439,7 +1439,7 @@ public void testGetObject_Failure() throws IOException {
     when(entity.getContent()).thenReturn(inputStream);
 
     List<String> objectInfo = sdmServiceImpl.getObject(objectId, sdmCredentials, false);
-    assertNull(objectInfo);
+    assertTrue(objectInfo.isEmpty());
   }
 
   @Test