Skip to content

Commit 4f2bfdb

Browse files
committed
Fix failure due to immutability changes
1 parent ad09c7b commit 4f2bfdb

3 files changed

Lines changed: 6 additions & 10 deletions

File tree

sdm/src/main/java/com/sap/cds/sdm/model/AttachmentMoveContext.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.sap.cds.sdm.model;
22

33
import com.sap.cds.reflect.CdsEntity;
4-
import java.util.Collections;
54
import java.util.List;
65
import java.util.Map;
76

@@ -57,6 +56,6 @@ public AttachmentProcessingResults getProcessingResults() {
5756
}
5857

5958
public List<Map<String, String>> getFailedAttachments() {
60-
return Collections.unmodifiableList(failedAttachments);
59+
return failedAttachments;
6160
}
6261
}

sdm/src/main/java/com/sap/cds/sdm/model/DatabaseFailureContext.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.sap.cds.sdm.model;
22

33
import com.sap.cds.sdm.service.handler.AttachmentMoveEventContext;
4-
import java.util.Collections;
54
import java.util.List;
65
import java.util.Map;
76

@@ -64,8 +63,6 @@ public AttachmentMoveEventContext getContext() {
6463
}
6564

6665
public List<Map<String, String>> getFailedAttachments() {
67-
// Return an unmodifiable list with each map also wrapped as unmodifiable for deep immutability
68-
return Collections.unmodifiableList(
69-
failedAttachments.stream().map(Collections::unmodifiableMap).toList());
66+
return failedAttachments;
7067
}
7168
}

sdm/src/main/java/com/sap/cds/sdm/model/ValidatedAttachmentData.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.sap.cds.sdm.model;
22

33
import com.sap.cds.reflect.CdsEntity;
4-
import java.util.Collections;
4+
import com.sap.cds.sdm.service.CmisDocument;
55
import java.util.List;
66
import java.util.Map;
77
import org.json.JSONObject;
@@ -81,15 +81,15 @@ public CdsEntity getTargetEntity() {
8181
}
8282

8383
public List<String> getSuccessfulObjectIds() {
84-
return List.copyOf(successfulObjectIds);
84+
return successfulObjectIds;
8585
}
8686

8787
public List<List<String>> getMovedAttachmentsMetadata() {
88-
return Collections.unmodifiableList(movedAttachmentsMetadata);
88+
return movedAttachmentsMetadata;
8989
}
9090

9191
public List<CmisDocument> getPopulatedDocuments() {
92-
return Collections.unmodifiableList(populatedDocuments);
92+
return populatedDocuments;
9393
}
9494

9595
public CmisDocument getSourceCmisDocument() {

0 commit comments

Comments
 (0)