Skip to content

Commit 4f030c0

Browse files
committed
Remove unused parameters & variables
1 parent e483a74 commit 4f030c0

4 files changed

Lines changed: 4 additions & 6 deletions

File tree

sdm/src/main/java/com/sap/cds/sdm/service/SDMServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ public int updateAttachments(
292292
}
293293

294294
SDMUtils.prepareSecondaryProperties(
295-
updateRequestBody, secondaryProperties, fileName, isSecondaryPropertiesUpdated);
295+
updateRequestBody, secondaryProperties, isSecondaryPropertiesUpdated);
296296
MultipartEntityBuilder builder = MultipartEntityBuilder.create();
297297
SDMUtils.assembleRequestBodySecondaryTypes(
298298
builder, updateRequestBody, objectId); // Adding Secondary Properties to the request body

sdm/src/main/java/com/sap/cds/sdm/utilities/SDMUtils.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ public static boolean isRestrictedCharactersInName(String cmisName) {
8484
public static void prepareSecondaryProperties(
8585
Map<String, String> requestBody,
8686
Map<String, String> secondaryProperties,
87-
String fileName,
8887
boolean isSecondaryPropertiesUpdated) {
8988
Iterator<Map.Entry<String, String>> iterator = secondaryProperties.entrySet().iterator();
9089

sdm/src/test/java/unit/com/sap/cds/sdm/service/SDMServiceImplTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1737,7 +1737,6 @@ public void testGetChangeLog_Success() throws IOException {
17371737
CloseableHttpResponse changeLogResponse1 = mock(CloseableHttpResponse.class);
17381738
HttpEntity repositoryEntity = mock(HttpEntity.class);
17391739
HttpEntity changeLogEntity = mock(HttpEntity.class);
1740-
StatusLine repositoryStatusLine = mock(StatusLine.class);
17411740
StatusLine changeLogStatusLine = mock(StatusLine.class);
17421741

17431742
when(tokenHandler.getHttpClient(any(), any(), any(), eq("TECHNICAL_CREDENTIALS_FLOW")))

sdm/src/test/java/unit/com/sap/cds/sdm/utilities/SDMUtilsTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ public void prepareSecondaryPropertiesTest_withFilenameKey() {
148148
Map<String, String> secondaryProperties = new HashMap<>();
149149
secondaryProperties.put("filename", "myfile.txt");
150150

151-
SDMUtils.prepareSecondaryProperties(requestBody, secondaryProperties, "myfile.txt", true);
151+
SDMUtils.prepareSecondaryProperties(requestBody, secondaryProperties, true);
152152

153153
assertEquals("cmis:name", requestBody.get("propertyId[1]"));
154154
assertEquals("myfile.txt", requestBody.get("propertyValue[1]"));
@@ -161,7 +161,7 @@ public void testPrepareSecondaryProperties_withOtherKeys() {
161161
secondaryProperties.put("author", "test user");
162162
secondaryProperties.put("subject", "JUnit Testing");
163163

164-
SDMUtils.prepareSecondaryProperties(requestBody, secondaryProperties, "testfile.txt", true);
164+
SDMUtils.prepareSecondaryProperties(requestBody, secondaryProperties, true);
165165

166166
assertEquals("author", requestBody.get("propertyId[1]"));
167167
assertEquals("test user", requestBody.get("propertyValue[1]"));
@@ -174,7 +174,7 @@ public void testPrepareSecondaryProperties_emptySecondaryProperties() {
174174
Map<String, String> requestBody = new HashMap<>();
175175
Map<String, String> secondaryProperties = new HashMap<>();
176176

177-
SDMUtils.prepareSecondaryProperties(requestBody, secondaryProperties, "emptyfile.txt", true);
177+
SDMUtils.prepareSecondaryProperties(requestBody, secondaryProperties, true);
178178

179179
assertTrue(requestBody.isEmpty());
180180
}

0 commit comments

Comments
 (0)