addressing gemini review comments

Author: rishikunnath2747

sdm/src/main/java/com/sap/cds/sdm/handler/applicationservice/SDMCreateAttachmentsHandler.java

@@ -245,7 +245,8 @@ private void processAttachment(
     // Update filename and description properties
     AttachmentsHandlerUtils.updateFilenameProperty(
         fileNameInDB, filenameInRequest, updatedSecondaryProperties);
-    updateDescriptionForCreate(descriptionInRequest, updatedSecondaryProperties);
+    AttachmentsHandlerUtils.updateDescriptionProperty(
+        descriptionInSDM, descriptionInRequest, updatedSecondaryProperties);
 
     // Send update to SDM and handle response
     try {
@@ -281,13 +282,6 @@ private void processAttachment(
     }
   }
 
-  private void updateDescriptionForCreate(
-      String descriptionInRequest, Map<String, String> updatedSecondaryProperties) {
-    if (descriptionInRequest != null) {
-      updatedSecondaryProperties.put("description", descriptionInRequest);
-    }
-  }
-
   private void handleWarnings(
       CdsCreateEventContext context,
       List<String> fileNameWithRestrictedCharacters,

sdm/src/main/java/com/sap/cds/sdm/handler/applicationservice/helper/AttachmentsHandlerUtils.java

@@ -694,10 +694,10 @@ public static void handleSDMUpdateResponse(
             attachment, fileNameInSDM, propertiesInDB, secondaryTypeProperties, descriptionInSDM);
         break;
       case 404:
-        filesNotFound.add(filenameInRequest);
+        filesNotFound.add(fileNameInSDM);
         revertAttachmentProperties(
             attachment,
-            filenameInRequest,
+            fileNameInSDM,
             propertiesInDB,
             secondaryTypeProperties,
             descriptionInSDM);

sdm/src/test/java/unit/com/sap/cds/sdm/service/SDMServiceImplTest.java

@@ -1295,7 +1295,6 @@ public void testValidSecondaryPropertiesFail() throws IOException {
       Cache<SecondaryPropertiesKey, List<String>> mockCache = Mockito.mock(Cache.class);
       Mockito.when(mockCache.get(any())).thenReturn(null);
 
-      //
       cacheConfigMockedStatic.when(CacheConfig::getSecondaryPropertiesCache).thenReturn(mockCache);
       String grantType = "TOKEN_EXCHANGE";
       when(tokenHandler.getHttpClient(any(), any(), any(), eq(grantType))).thenReturn(httpClient);
@@ -1339,7 +1338,6 @@ public void testValidSecondaryPropertiesFailEmptyResponse() throws IOException {
       Cache<SecondaryPropertiesKey, List<String>> mockCache = Mockito.mock(Cache.class);
       Mockito.when(mockCache.get(any())).thenReturn(secondaryTypesCached);
 
-      //
       cacheConfigMockedStatic.when(CacheConfig::getSecondaryPropertiesCache).thenReturn(mockCache);
       cacheConfigMockedStatic.when(CacheConfig::getSecondaryTypesCache).thenReturn(mockCache);