github-code-quality security fix

Author: yashmeet29

sdm/src/main/java/com/sap/cds/sdm/model/AttachmentMoveContext.java

@@ -1,6 +1,7 @@
 package com.sap.cds.sdm.model;
 
 import com.sap.cds.reflect.CdsEntity;
+import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 
@@ -56,6 +57,14 @@ public AttachmentProcessingResults getProcessingResults() {
   }
 
   public List<Map<String, String>> getFailedAttachments() {
-    return failedAttachments;
+    return Collections.unmodifiableList(failedAttachments);
+  }
+
+  /**
+   * Internal method for adding failed attachments during processing. For internal use only - do not
+   * expose to external callers.
+   */
+  public void addFailedAttachment(Map<String, String> failure) {
+    failedAttachments.add(failure);
   }
 }

sdm/src/main/java/com/sap/cds/sdm/model/DatabaseFailureContext.java

@@ -1,6 +1,7 @@
 package com.sap.cds.sdm.model;
 
 import com.sap.cds.sdm.service.handler.AttachmentMoveEventContext;
+import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 
@@ -63,6 +64,14 @@ public AttachmentMoveEventContext getContext() {
   }
 
   public List<Map<String, String>> getFailedAttachments() {
-    return failedAttachments;
+    return Collections.unmodifiableList(failedAttachments);
+  }
+
+  /**
+   * Internal method for adding failed attachments during processing. For internal use only - do not
+   * expose to external callers.
+   */
+  public void addFailedAttachment(Map<String, String> failure) {
+    failedAttachments.add(failure);
   }
 }

sdm/src/main/java/com/sap/cds/sdm/model/ValidatedAttachmentData.java

@@ -1,6 +1,7 @@
 package com.sap.cds.sdm.model;
 
 import com.sap.cds.reflect.CdsEntity;
+import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import org.json.JSONObject;
@@ -80,15 +81,39 @@ public CdsEntity getTargetEntity() {
   }
 
   public List<String> getSuccessfulObjectIds() {
-    return successfulObjectIds;
+    return Collections.unmodifiableList(successfulObjectIds);
   }
 
   public List<List<String>> getMovedAttachmentsMetadata() {
-    return movedAttachmentsMetadata;
+    return Collections.unmodifiableList(movedAttachmentsMetadata);
   }
 
   public List<CmisDocument> getPopulatedDocuments() {
-    return populatedDocuments;
+    return Collections.unmodifiableList(populatedDocuments);
+  }
+
+  /**
+   * Internal method for adding successful object IDs during processing. For internal use only - do
+   * not expose to external callers.
+   */
+  public void addSuccessfulObjectId(String objectId) {
+    successfulObjectIds.add(objectId);
+  }
+
+  /**
+   * Internal method for adding moved attachments metadata during processing. For internal use only
+   * - do not expose to external callers.
+   */
+  public void addMovedAttachmentMetadata(List<String> metadata) {
+    movedAttachmentsMetadata.add(metadata);
+  }
+
+  /**
+   * Internal method for adding populated documents during processing. For internal use only - do
+   * not expose to external callers.
+   */
+  public void addPopulatedDocument(CmisDocument document) {
+    populatedDocuments.add(document);
   }
 
   public CmisDocument getSourceCmisDocument() {

sdm/src/main/java/com/sap/cds/sdm/service/handler/SDMCustomServiceHandler.java

@@ -759,7 +759,7 @@ private void processSingleAttachmentMove(AttachmentMoveContext moveContext) {
       Map<String, String> failure = new HashMap<>();
       failure.put(OBJECT_ID_KEY, moveContext.getObjectId());
       failure.put(FAILURE_REASON_KEY, "SDM move failed: " + e.getMessage());
-      moveContext.getFailedAttachments().add(failure);
+      moveContext.addFailedAttachment(failure);
     } catch (Exception e) {
       // Validation/processing failed
       logger.error(
@@ -770,7 +770,7 @@ private void processSingleAttachmentMove(AttachmentMoveContext moveContext) {
       Map<String, String> failure = new HashMap<>();
       failure.put(OBJECT_ID_KEY, moveContext.getObjectId());
       failure.put(FAILURE_REASON_KEY, "Validation/processing failed: " + e.getMessage());
-      moveContext.getFailedAttachments().add(failure);
+      moveContext.addFailedAttachment(failure);
     }
   }
 
@@ -801,15 +801,14 @@ private void processValidatedAttachment(ValidatedAttachmentData data) {
         filteredSecondaryProps);
 
     // Add to successful results
-    data.getSuccessfulObjectIds().add(data.getObjectId());
-    data.getMovedAttachmentsMetadata()
-        .add(
-            List.of(
-                data.getFileName(),
-                data.getMimeType(),
-                data.getDescription(),
-                data.getMovedObjectId()));
-    data.getPopulatedDocuments().add(populatedDocument);
+    data.addSuccessfulObjectId(data.getObjectId());
+    data.addMovedAttachmentMetadata(
+        List.of(
+            data.getFileName(),
+            data.getMimeType(),
+            data.getDescription(),
+            data.getMovedObjectId()));
+    data.addPopulatedDocument(populatedDocument);
   }
 
   /**