Revert code changes to disable upload button

Author: yashmeet29

.github/workflows/cfdeploy.yml

@@ -55,12 +55,12 @@ jobs:
       - name: Verify and Checkout Deploy Branch 🔄
         run: |
           git fetch origin
-          echo "📂 Verifying 'local_deploy' branch..."
-          if git rev-parse --verify origin/local_deploy; then
-            git checkout local_deploy
+          echo "📂 Verifying 'revertChangesToDisableUploadBtn' branch..."
+          if git rev-parse --verify origin/revertChangesToDisableUploadBtn; then
+            git checkout revertChangesToDisableUploadBtn
             echo "✅ Branch checked out successfully!"
           else
-            echo "❌ Branch 'local_deploy' not found. Please verify the branch name."
+            echo "❌ Branch 'revertChangesToDisableUploadBtn' not found. Please verify the branch name."
             exit 1
           fi
 

README.md

@@ -26,7 +26,6 @@ This plugin can be consumed by the CAP application deployed on BTP to store thei
 - Localization of error messages and UI fields: Provides the capability to have the UI fields and error messages translated to the local language of the leading application.
 - Attachment Upload Status: Upload Status is the new field which displays the upload status of attachment when being uploaded.
 - Active entity attachment creation: Provides the capability to create attachments directly on active (non-draft) entities.
-- Upload button visibility control: Provides the capability to automatically show or hide the Upload button based on the configured `maxCount` limit.
 - Download attachments: Provides the capability to download multiple selected file attachments at once with smart button enablement.
 
 ## Table of Contents
@@ -49,7 +48,6 @@ This plugin can be consumed by the CAP application deployed on BTP to store thei
 - [Support for Localization](#support-for-localization)
 - [Support for Attachment Upload Status](#support-for-attachment-upload-status)
 - [Support for Attachment creation in Active Entities](#support-for-attachment-creation-in-active-entities)
-- [Support for Upload Button Visibility Control](#support-for-upload-button-visibility-control)
 - [Support for Download Attachments](#support-for-download-attachments)
 - [Known Restrictions](#known-restrictions)
 - [Support, Feedback, Contributing](#support-feedback-contributing)
@@ -1398,74 +1396,6 @@ To create attachments on active entities, the leading application needs to trigg
        Insert.into("MyService.MyEntity.attachments").entry(attachmentData)
    );
 
-## Support for Upload Button Visibility Control
-
-The plugin can automatically **hide the Upload button** once the configured `maxCount` is reached, and **re-enable it** when an attachment is deleted and the count drops back below the limit. This gives end users immediate visual feedback about whether further uploads are allowed, without relying solely on an error message after the attempt.
-
-### How It Works
-
-1. **On upload (create):** After a successful upload, the plugin compares the current attachment count with `maxCount`. If the count reaches or exceeds `maxCount`, a boolean flag on the parent entity (e.g. `isAttachmentsUploadable`) is set to `false`. The UI reads this flag via a `Capabilities` annotation and hides the Upload button.
-2. **On delete:** After an attachment is deleted, if the remaining count is below `maxCount`, the same flag is set back to `true` and the Upload button reappears.
-
-### Usage in Leading Applications
-
-#### Step 1 — Add a boolean field to the parent entity
-
-Add a boolean field for each attachment facet that should have Upload button control. The field name must follow the pattern `is<FacetName>Uploadable` where `<FacetName>` is the capitalised name of the composition (e.g. `attachments` → `isAttachmentsUploadable`).
-
-```cds
-entity Books {
-  key ID : UUID;
-  ...
-  isAttachmentsUploadable : Boolean default true;
-  attachments             : Composition of many Attachments @SDM.Attachments:{ maxCount: 4 };
-}
-```
-
-> **Note:** Initialise the field to `true` so the Upload button is visible before any attachment is added.
-
-#### Step 2 — Annotate the composition at the service layer
-
-Use the `@Capabilities.InsertRestrictions.Insertable` annotation to bind the Upload button visibility to the flag on the parent entity:
-
-```cds
-annotate MyService.Books.attachments with @(
-  Capabilities: {
-    InsertRestrictions: {
-      Insertable: up_.isAttachmentsUploadable
-    }
-  }
-);
-```
-
-The `up_` navigation property refers to the parent `Books` entity. The UI framework reads this annotation and enables or disables the Upload button accordingly.
-
-#### Multiple facets
-
-For each additional facet, add its own boolean field and annotation:
-
-```cds
-entity Books {
-  key ID : UUID;
-  ...
-  isAttachmentsUploadable : Boolean default true;
-  isReferencesUploadable  : Boolean default true;
-  attachments             : Composition of many Attachments @SDM.Attachments:{ maxCount: 4 };
-  references              : Composition of many Attachments @SDM.Attachments:{ maxCount: 3 };
-}
-```
-
-```cds
-annotate MyService.Books.attachments with @(
-  Capabilities: { InsertRestrictions: { Insertable: up_.isAttachmentsUploadable } }
-);
-annotate MyService.Books.references with @(
-  Capabilities: { InsertRestrictions: { Insertable: up_.isReferencesUploadable } }
-);
-```
-
-> **Note:** No additional Java or configuration changes are required in the leading application. The plugin derives the field name from the facet's composition name automatically.
-
 ## Support for Download Attachments
 
 This plugin provides the capability to download multiple selected file attachments at once. The Download button is automatically disabled when any link-type attachment is selected, since links are meant to be opened in the browser and not downloaded as files.

sdm/src/main/java/com/sap/cds/sdm/persistence/DBQuery.java

@@ -1138,76 +1138,4 @@ private String resolveUpIdKey(CdsModel model, String parentEntity, String compos
 
     return null;
   }
-
-  /**
-   * Looks up the parent ID (up__ID) of an attachment by its objectId.
-   *
-   * @param attachmentEntity the attachment entity to query
-   * @param persistenceService the persistence service
-   * @param objectId the SDM objectId of the attachment
-   * @param upIdKey the field name for the parent ID (e.g. "up__ID")
-   * @return the parent ID string, or null if not found
-   */
-  public String getUpIdByObjectId(
-      CdsEntity attachmentEntity,
-      PersistenceService persistenceService,
-      String objectId,
-      String upIdKey) {
-    logger.debug(
-        "Fetching {} for objectId: {} from entity: {}",
-        upIdKey,
-        objectId,
-        attachmentEntity.getQualifiedName());
-    CqnSelect q =
-        Select.from(attachmentEntity)
-            .columns(upIdKey)
-            .where(doc -> doc.get("objectId").eq(objectId));
-    Result result = persistenceService.run(q);
-    return result
-        .first()
-        .map(row -> row.get(upIdKey) != null ? row.get(upIdKey).toString() : null)
-        .orElse(null);
-  }
-
-  /**
-   * Updates the isUploadable flag on the parent entity row that owns the attachment composition.
-   * One row updated instead of N attachment rows.
-   *
-   * @param parentEntity the parent CDS entity (e.g. Books or Books_drafts)
-   * @param persistenceService the persistence service
-   * @param parentId the parent entity's key value
-   * @param parentKeyField the parent entity's key field name (e.g. "ID")
-   * @param isUploadable the new value of the isUploadable flag
-   */
-  public long updateIsUploadableOnParentEntity(
-      CdsEntity parentEntity,
-      PersistenceService persistenceService,
-      String parentId,
-      String parentKeyField,
-      String facetField,
-      boolean isUploadable) {
-    logger.debug(
-        "Updating {}={} on parent entity: {} for {}={}",
-        facetField,
-        isUploadable,
-        parentEntity.getQualifiedName(),
-        parentKeyField,
-        parentId);
-    Map<String, Object> updatedFields = new HashMap<>();
-    updatedFields.put(facetField, isUploadable);
-    CqnUpdate updateQuery =
-        Update.entity(parentEntity)
-            .data(updatedFields)
-            .where(e -> e.get(parentKeyField).eq(parentId));
-    Result updateResult = persistenceService.run(updateQuery);
-    logger.info(
-        "Updated {}={} for {} row(s) on {} where {}={}",
-        facetField,
-        isUploadable,
-        updateResult.rowCount(),
-        parentEntity.getQualifiedName(),
-        parentKeyField,
-        parentId);
-    return updateResult.rowCount();
-  }
 }