Skip to content

Filter extra args in TestTokenV2.SettlementFactory_SettleBatch #5954

@meiersi-da

Description

@meiersi-da

Problem

TestTokenV2.SettlementFactory_SettleBatch extra args are carry the account-configs of all allocations that are being settled. The current implementation passes them unchanged to all Allocation_Settle calls. Thus leaking the account configs of all counter-parties.

Proposal

  1. change the default settleBatch implementation in token-standard-utils to take a filterExtraArgs argument
  2. use that in the TestTokenV2 implementation to remove this privacy leak

Kudos to @johan-da for discovering this problem.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdaml-apiDaml API change.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions