From 0ac6e033eaf9b78b1bb021adbba41b3be11afb45 Mon Sep 17 00:00:00 2001 From: Vincent Fretin Date: Sat, 25 Apr 2026 20:31:45 +0200 Subject: [PATCH] Fix crash in selectionBox when gltf-model loads after entity is detached Co-Authored-By: Claude Opus 4.7 (1M context) --- src/lib/viewport.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/viewport.js b/src/lib/viewport.js index e592968e7..458e07a8d 100644 --- a/src/lib/viewport.js +++ b/src/lib/viewport.js @@ -162,9 +162,10 @@ export function Viewport(inspector) { } else if (object.el.hasAttribute('gltf-model')) { const listener = (event) => { if (event.target !== object.el) return; // we got an event for a child, ignore + object.el.removeEventListener('model-loaded', listener); + if (object.parent === null) return; // entity was detached before model loaded selectionBox.setFromObject(object); selectionBox.visible = true; - object.el.removeEventListener('model-loaded', listener); }; object.el.addEventListener('model-loaded', listener); }