Skip to content

--validate-component isn't actually on by default #97

@lann

Description

@lann

/// Whether or not the output component is validated.
///
/// This defaults to `true`.
#[clap(long)]
validate_component: Option<bool>,

if let Some(validate) = self.component.validate_component {
encoder = encoder.validate(validate);
}

https://github.com/bytecodealliance/wasm-tools/blob/74145d2038c70d984eaf55cac17b7a05f2326523/crates/wit-component/src/encoding.rs#L3116-L3120

#[derive(Default)]
pub struct ComponentEncoder {
    ...
    validate: bool,

It seems like it might make sense to just change the ComponentEncoder default?

Ref bytecodealliance/wit-bindgen#1622 (which combined with this made for a very confusing debug session 😅)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions